Skip to content

OCPBUGS-26498: Vendor route API change for UnservableInFutureVersions status#414

Closed
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:OCPBUGS-26498
Closed

OCPBUGS-26498: Vendor route API change for UnservableInFutureVersions status#414
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:OCPBUGS-26498

Conversation

@gcs278
Copy link
Contributor

@gcs278 gcs278 commented Jan 24, 2024

Vendor the route API change in openshift/api#1722 in order to get the GO doc updates for oc explain route.status.ingress.conditions since the UnservableInFutureVersions status condition type was added.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 24, 2024
@openshift-ci-robot
Copy link

@gcs278: This pull request references Jira Issue OCPBUGS-26498, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

WIP: Uses K8S 1.28 API (release-1.15) because I got stumped trying to vendor my API changes with K8S 1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 24, 2024
@gcs278 gcs278 force-pushed the OCPBUGS-26498 branch 3 times, most recently from abeedc4 to 58eb250 Compare April 15, 2024 23:09
@gcs278 gcs278 changed the title WIP: OCPBUGS-26498: Vendor route API change for degraded status OCPBUGS-26498: Vendor route API change for degraded status Apr 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
@gcs278 gcs278 changed the title OCPBUGS-26498: Vendor route API change for degraded status OCPBUGS-26498: Vendor route API change for UnservableInFutureVersions status Apr 15, 2024
Vendoring API to update the go docs for UnservableInFutureVersions condition.

`go get github.com/openshift/api@v0.0.0-20240202140003-8b34b9854c7f`
@gcs278
Copy link
Contributor Author

gcs278 commented Apr 23, 2024

I'll do a sanity check test, but feel free to review
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@gcs278
Copy link
Contributor Author

gcs278 commented Apr 23, 2024

Sanity checked ✔️
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frobware, gcs278
Once this PR has been reviewed and has the lgtm label, please assign benluddy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

No longer needed as openshift/api was bumped to also include the route API update in #407
/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Apr 30, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@gcs278: Closed this PR.

Details

In response to this:

No longer needed as openshift/api was bumped to also include the route API update in #407
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@gcs278: This pull request references Jira Issue OCPBUGS-26498. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Vendor the route API change in openshift/api#1722 in order to get the GO doc updates for oc explain route.status.ingress.conditions since the UnservableInFutureVersions status condition type was added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants