Skip to content

Fix ListModel conversion to primitive#65

Merged
bradmwilliams merged 1 commit intoopenshift:mainfrom
jupierce:list_model
Jul 18, 2020
Merged

Fix ListModel conversion to primitive#65
bradmwilliams merged 1 commit intoopenshift:mainfrom
jupierce:list_model

Conversation

@jupierce
Copy link
Copy Markdown
Contributor

_primitive is supposed to return any Model (recursively) back into a normal dict/list. Complex list elements were not being converted.

@jupierce jupierce requested a review from bradmwilliams July 18, 2020 02:35
Copy link
Copy Markdown
Contributor

@bradmwilliams bradmwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2020
@bradmwilliams bradmwilliams merged commit 0024aa3 into openshift:main Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants