Skip to content

OSDOCS-16393: Added ROSA CLI commands for deleting and listing AWS resources.#100165

Merged
EricPonvelle merged 1 commit intoopenshift:mainfrom
EricPonvelle:OSDOCS-16393_New-CLI-command
Oct 15, 2025
Merged

OSDOCS-16393: Added ROSA CLI commands for deleting and listing AWS resources.#100165
EricPonvelle merged 1 commit intoopenshift:mainfrom
EricPonvelle:OSDOCS-16393_New-CLI-command

Conversation

@EricPonvelle
Copy link
Contributor

@EricPonvelle EricPonvelle commented Oct 7, 2025

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2025

@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

  • ROSA CLI reference guide
    • Deleting command updates
    • Listing command updates

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 7, 2025

@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch from d82934c to ae0b7ff Compare October 7, 2025 22:46
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2025

@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch 7 times, most recently from 5620cbf to 4e61285 Compare October 8, 2025 23:10
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2025
@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch from 4e61285 to 678e05b Compare October 9, 2025 20:54
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 9, 2025
@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch from 678e05b to 64f0dfe Compare October 9, 2025 22:12
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025

@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Version(s):
enterprise-4.19+

Issue:
OSDOCS-16393

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch 3 times, most recently from ae2a3b4 to 7a2712d Compare October 13, 2025 17:40
@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch 4 times, most recently from fa18129 to b0331af Compare October 13, 2025 18:29
@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch from b0331af to f70dab3 Compare October 13, 2025 21:23
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work on a long PR. The main discrepancy seems to be alternating between verbs that end in "s" and ones that do not, for example "List" vs. "Lists". I prefer "lists", but really it just needs to be consistent throughout. I marked some, but did not mark every instance in the entire doc.

Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work on a long PR. The main discrepancy seems to be alternating between verbs that end in "s" and ones that do not, for example "List" vs. "Lists". I prefer "lists", but really it just needs to be consistent throughout. I marked some, but did not mark every instance in the entire doc.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-16393_New-CLI-command branch from f70dab3 to c6e2d43 Compare October 15, 2025 15:30
@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

@EricPonvelle: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EricPonvelle EricPonvelle merged commit 76dd878 into openshift:main Oct 15, 2025
2 checks passed
@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #100536

Details

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #100537

Details

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants