OSDOCS-16393: Added ROSA CLI commands for deleting and listing AWS resources.#100165
Conversation
|
@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d82934c to
ae0b7ff
Compare
|
@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5620cbf to
4e61285
Compare
4e61285 to
678e05b
Compare
678e05b to
64f0dfe
Compare
|
@EricPonvelle: This pull request references OSDOCS-16393 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ae2a3b4 to
7a2712d
Compare
fa18129 to
b0331af
Compare
b0331af to
f70dab3
Compare
jneczypor
left a comment
There was a problem hiding this comment.
Really great work on a long PR. The main discrepancy seems to be alternating between verbs that end in "s" and ones that do not, for example "List" vs. "Lists". I prefer "lists", but really it just needs to be consistent throughout. I marked some, but did not mark every instance in the entire doc.
jneczypor
left a comment
There was a problem hiding this comment.
Really great work on a long PR. The main discrepancy seems to be alternating between verbs that end in "s" and ones that do not, for example "List" vs. "Lists". I prefer "lists", but really it just needs to be consistent throughout. I marked some, but did not mark every instance in the entire doc.
f70dab3 to
c6e2d43
Compare
|
@EricPonvelle: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.19 |
|
@EricPonvelle: new pull request created: #100536 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@EricPonvelle: new pull request created: #100537 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
enterprise-4.19+Issue:
OSDOCS-16393
Link to docs preview:
QE review:
Additional information:
This PR adds a few ROSA CLI options to list and delete AWS resources.