Skip to content

BZ-1683136: Updated instructions to use route instead of master.#13932

Merged
huffmanca merged 1 commit intoopenshift:enterprise-4.0from
huffmanca:BZ1683136
Mar 20, 2019
Merged

BZ-1683136: Updated instructions to use route instead of master.#13932
huffmanca merged 1 commit intoopenshift:enterprise-4.0from
huffmanca:BZ1683136

Conversation

@huffmanca
Copy link
Contributor

BZ-1683136: Updated instructions to use route instead of master for token requests.

This is for OS 4.0.

@huffmanca huffmanca requested a review from barleyer March 1, 2019 18:20
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2019
@huffmanca
Copy link
Contributor Author

@barleyer,

I only saw one section that referenced /oauth/token/request, and this has been updated. I do see several references to /oauth/authorize. Should these be updated to use the route as well?

@huffmanca huffmanca added this to the Next Release milestone Mar 1, 2019
@barleyer
Copy link

barleyer commented Mar 9, 2019

I only saw one section that referenced /oauth/token/request, and this has been updated. I do see several references to /oauth/authorize. Should these be updated to use the route as well?

I think so. Better confirm with @enj

@enj
Copy link

enj commented Mar 9, 2019

@barleyer,

I only saw one section that referenced /oauth/token/request, and this has been updated. I do see several references to /oauth/authorize. Should these be updated to use the route as well?

Yes.

@barleyer
Copy link

@enj thanks.

@vikram-redhat
Copy link
Contributor

@huffmanca can this be merged?

@huffmanca
Copy link
Contributor Author

@vikram-redhat ,

I need to update all of the references to the oauth server. I'll work on doing this one before EoD tomorrow.

@openshift-docs-preview-bot

The preview will be availble shortly at:

@huffmanca
Copy link
Contributor Author

@barleyer ,

I've updated all of there references to /oauth/*. Further enhancements need to be made to these sections to more clearly indicate how to use the oauth API, but these will be tracked under a separate issue.

This one should be ready for rereview.

@barleyer
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2019
@vikram-redhat
Copy link
Contributor

@huffmanca is this now waiting on peer review?

@huffmanca
Copy link
Contributor Author

These changes are fairly minor, and I don't believe a peer review is necessary. Merging and closing this one out.

@huffmanca huffmanca merged commit 7649a63 into openshift:enterprise-4.0 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.1 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants