Skip to content

Add ScheduleDSPods#14751

Merged
mburke5678 merged 1 commit intoopenshift:enterprise-4.1from
mburke5678:issue-14629
May 22, 2019
Merged

Add ScheduleDSPods#14751
mburke5678 merged 1 commit intoopenshift:enterprise-4.1from
mburke5678:issue-14629

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented May 8, 2019

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2019
@mburke5678
Copy link
Contributor Author

mburke5678 commented May 8, 2019

@ravisantoshgudimetla PTAL. Is there a use case for turning off the ScheduleDaemonSetPods feature?

@mburke5678 mburke5678 added this to the Future Release milestone May 8, 2019
@mburke5678
Copy link
Contributor Author

mburke5678 commented May 14, 2019 •
edited
Loading

@ravisantoshgudimetla PTAL. I want to make sure the edit I made to your PR do not change the technical details.

Also, is there a use case for turning off the ScheduleDaemonSetPods feature?

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented May 14, 2019

Also, is there a use case for turning off the ScheduleDaemonSetPods feature?

Nope, we are not exposing that.

ravisantoshgudimetla
ravisantoshgudimetla approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@sjenning
Copy link

sjenning commented May 15, 2019 •
edited
Loading

@mburke5678 can you remove every after line 25. we don't let the user disable ScheduleDaemonSetPods so not point mentioning what happens in that case.

Otherwise, LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@mburke5678
Copy link
Contributor Author

mburke5678 commented May 15, 2019

@weinliu Is this something you can review from the QE side?

@mburke5678 mburke5678 added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed tech_review labels May 15, 2019
@mburke5678
Copy link
Contributor Author

mburke5678 commented May 20, 2019

@weinliu Please take a look. we are trying to close all PRs by the end of the week for GA.
If you cannot review, can you suggest someone who can?

cc. @xltian

@weinliu
Copy link

weinliu commented May 21, 2019

@mburke5678 ,sorry for missing this, I just got the doc reviewed, it LGTM. I'm checking on if anything else missed. @me if I did not figure them out

@mburke5678 mburke5678 removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 22, 2019
@mburke5678 mburke5678 merged commit dc55273 into openshift:enterprise-4.1 May 22, 2019
@mburke5678 mburke5678 deleted the issue-14629 branch May 22, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ravisantoshgudimetla ravisantoshgudimetla

Labels

branch/enterprise-4.1 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.1 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@mburke5678 @ravisantoshgudimetla @sjenning @openshift-ci-robot @weinliu @vikram-redhat