Enable caching for content per Google PageSpeed Insights recommendation#15218
Merged
jboxman merged 1 commit intoopenshift:masterfrom Oct 17, 2019
Merged
Conversation
Contributor
|
This is great. Yes, we should do this. The only thing I would remove is text/html for which we should not have any caching (due to fires which require immediate updates.) |
Contributor
|
Also poor vikram-raj is probably not sure why he got tagged :) |
Contributor
Author
|
@vikram-redhat I blame auto-complete :) |
Contributor
Author
|
@vikram-redhat if Apache is going away, I need to reformulate this. |
Contributor
|
@jboxman yes this will need to change. I can't recall why we didn't merge it already though? |
Contributor
Author
|
@vikram-redhat, you wanted it to leave the behavior for caching HTML pages alone so users receive updates as soon as possible. |
Contributor
|
@jboxman correct, so it just means we take the text/html part out and then merge the rest. |
Contributor
Author
|
@vikram-redhat, true. |
9fa2e95 to
e1c4b36
Compare
Contributor
Author
|
@vikram-redhat, did we ever move to Nginx? |
Contributor
|
@jboxman no we didn't :) Merge away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I've been thinking about this for a few months now. Currently, we don't provide an
Expiresheader. An optimal strategy will require additional research and discussion, but I wanted to open this now anyway.