Add the user workload monitoring documentation by rh-max · Pull Request #18788 · openshift/openshift-docs

rh-max · 2019-12-20T04:51:54Z

No description provided.

openshift-docs-preview-bot · 2019-12-20T15:06:15Z

The preview will be available shortly at:

https://enterprise-4.3-monitoring-user-workload--ocpdocs.netlify.com/

modules/monitoring-accessing-user-workload-metrics.adoc

modules/monitoring-enabling-user-workload-monitoring.adoc

modules/monitoring-deploying-a-sample-application.adoc

modules/monitoring-accessing-user-workload-metrics.adoc

modules/monitoring-granting-a-user-access-to-metrics.adoc

modules/monitoring-enabling-user-workload-monitoring.adoc

modules/monitoring-examining-metrics-as-a-developer.adoc

modules/monitoring-deploying-a-sample-application.adoc

monitoring/user-workload-monitoring.adoc

s-urbaniak · 2020-01-09T08:05:45Z

/cc @openshift/openshift-team-monitoring

modules/monitoring-examining-metrics-as-a-developer.adoc

modules/monitoring-accessing-user-workload-metrics.adoc

Co-Authored-By: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

vikram-redhat · 2020-01-16T02:51:00Z

@rh-max has QE team reviewed it?

juzhao

LGTM, all the changes are implemented

modules/monitoring-setting-up-metrics-collection.adoc

sheriff-rh

Great work, Max!

rh-max · 2020-01-21T17:24:27Z

@sheriff-rh This PR has developer, QE, and doc team ACKs. Could you please merge this and cherry-pick into enterprise-4.3? Thanks.
Thanks a lot everybody!

sheriff-rh · 2020-01-21T18:05:05Z

/cherrypick enterprise-4.3

openshift-cherrypick-robot · 2020-01-21T18:05:16Z

@sheriff-rh: new pull request created: #19196

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-01-23T21:10:28Z

@sheriff-rh: #18788 failed to apply on top of branch "enterprise-4.3":

.git/rebase-apply/patch:967: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	_topic_map.yml
M	monitoring/cluster-monitoring/examining-cluster-metrics.adoc
Falling back to patching base and 3-way merge...
Auto-merging monitoring/cluster-monitoring/examining-cluster-metrics.adoc
CONFLICT (content): Merge conflict in monitoring/cluster-monitoring/examining-cluster-metrics.adoc
Auto-merging modules/monitoring-examining-metrics-as-a-developer.adoc
CONFLICT (add/add): Merge conflict in modules/monitoring-examining-metrics-as-a-developer.adoc
Auto-merging _topic_map.yml
CONFLICT (content): Merge conflict in _topic_map.yml
Patch failed at 0001 Add the user workload monitoring documentation

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-01-23T21:10:43Z

@sheriff-rh: #18788 failed to apply on top of branch "enterprise-4.3":

.git/rebase-apply/patch:967: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	_topic_map.yml
M	monitoring/cluster-monitoring/examining-cluster-metrics.adoc
Falling back to patching base and 3-way merge...
Auto-merging monitoring/cluster-monitoring/examining-cluster-metrics.adoc
CONFLICT (content): Merge conflict in monitoring/cluster-monitoring/examining-cluster-metrics.adoc
Auto-merging modules/monitoring-examining-metrics-as-a-developer.adoc
CONFLICT (add/add): Merge conflict in modules/monitoring-examining-metrics-as-a-developer.adoc
Auto-merging _topic_map.yml
CONFLICT (content): Merge conflict in _topic_map.yml
Patch failed at 0001 Add the user workload monitoring documentation

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-redhat · 2020-01-23T21:11:02Z

@rh-max 16 commits?

@sheriff-rh please make sure to request that commits are squashed and labels for peer review and branch and milestone are added.

rh-max · 2020-01-23T22:39:03Z

@vikram-redhat @sheriff-rh Damn, my bad, forgot to squash. Sorry.

fixing #18788

…-19320-to-enterprise-4.3 [enterprise-4.3] fixing #18788

…-19320-to-enterprise-4.4 [enterprise-4.4] fixing #18788

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2019

rh-max added 3 commits December 20, 2019 23:44

Add the user workload monitoring documentation

f8228c3

Remove two xrefs

ebf7d34

Move an xref from a module to the assembly

7fe68bc

rh-max force-pushed the enterprise-4.3-monitoring-user-workload branch from 17dcbee to 7fe68bc Compare December 20, 2019 22:45

Fix an xref

b89b91e

juzhao reviewed Dec 23, 2019

View reviewed changes

modules/monitoring-accessing-user-workload-metrics.adoc Outdated Show resolved Hide resolved

juzhao reviewed Dec 23, 2019

View reviewed changes

modules/monitoring-enabling-user-workload-monitoring.adoc Outdated Show resolved Hide resolved

juzhao reviewed Dec 23, 2019

View reviewed changes

s-urbaniak reviewed Jan 9, 2020

View reviewed changes

modules/monitoring-enabling-user-workload-monitoring.adoc Outdated Show resolved Hide resolved

s-urbaniak reviewed Jan 9, 2020

View reviewed changes

modules/monitoring-examining-metrics-as-a-developer.adoc Outdated Show resolved Hide resolved

s-urbaniak reviewed Jan 9, 2020

View reviewed changes

modules/monitoring-deploying-a-sample-application.adoc Show resolved Hide resolved

s-urbaniak reviewed Jan 9, 2020

View reviewed changes

monitoring/user-workload-monitoring.adoc Outdated Show resolved Hide resolved

simonpasquier reviewed Jan 9, 2020

View reviewed changes

modules/monitoring-examining-metrics-as-a-developer.adoc Outdated Show resolved Hide resolved

modules/monitoring-accessing-user-workload-metrics.adoc Outdated Show resolved Hide resolved

modules/monitoring-accessing-user-workload-metrics.adoc Outdated Show resolved Hide resolved

rh-max and others added 7 commits January 10, 2020 19:05

Small fixes

2d46784

Various improvements

b4dc611

Add a separate procedure for creating a ServiceMonitor

088fed1

Add the procedure for creating an alerting rule

f79f615

Add a detail on how user workload monitoring is enabled

264938e

Co-Authored-By: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

Some additional information on admins and developers

6842469

s/User workload monitoring/Monitoring your own services/ + many changes

4b9c816

rh-max added 3 commits January 20, 2020 12:02

Many changes

1d88b7a

Add a section on giving view permissions; many changes

dfedefe

Add a clarification

63f08aa

juzhao reviewed Jan 20, 2020

View reviewed changes

s-urbaniak reviewed Jan 20, 2020

View reviewed changes

modules/monitoring-setting-up-metrics-collection.adoc Show resolved Hide resolved

s-urbaniak reviewed Jan 20, 2020

View reviewed changes

modules/monitoring-setting-up-metrics-collection.adoc Show resolved Hide resolved

sheriff-rh approved these changes Jan 20, 2020

View reviewed changes

rh-max added 2 commits January 21, 2020 13:49

Add two notes, fix a link name

a3186c6

Add link to API docs

319b232

sheriff-rh merged commit 4a6310f into openshift:master Jan 21, 2020

openshift-cherrypick-robot mentioned this pull request Jan 21, 2020

[enterprise-4.3] Add the user workload monitoring documentation #19196

Merged

vikram-redhat added this to the OCP 4.3 GA milestone Jan 23, 2020

vikram-redhat added the branch/enterprise-4.3 label Jan 23, 2020

vikram-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 23, 2020

vikram-redhat added a commit to vikram-redhat/openshift-docs that referenced this pull request Jan 26, 2020

fixing openshift#18788

62d3056

vikram-redhat added a commit that referenced this pull request Jan 26, 2020

Merge pull request #19320 from vikram-redhat/master

999268b

fixing #18788

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Jan 26, 2020

fixing openshift#18788

a373df0

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Jan 26, 2020

fixing openshift#18788

3c031b4

vikram-redhat added a commit that referenced this pull request Jan 26, 2020

Merge pull request #19321 from openshift-cherrypick-robot/cherry-pick…

0b2eda3

…-19320-to-enterprise-4.3 [enterprise-4.3] fixing #18788

vikram-redhat added a commit that referenced this pull request Jan 26, 2020

Merge pull request #19322 from openshift-cherrypick-robot/cherry-pick…

6ec4636

…-19320-to-enterprise-4.4 [enterprise-4.4] fixing #18788

yuvalk mentioned this pull request Mar 18, 2021

cnf 4.6 references #30640

Closed

Conversation

rh-max commented Dec 20, 2019

Uh oh!

openshift-docs-preview-bot commented Dec 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s-urbaniak commented Jan 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vikram-redhat commented Jan 16, 2020

Uh oh!

juzhao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sheriff-rh left a comment

Choose a reason for hiding this comment

Uh oh!

rh-max commented Jan 21, 2020

Uh oh!

sheriff-rh commented Jan 21, 2020

Uh oh!

openshift-cherrypick-robot commented Jan 21, 2020

Uh oh!

openshift-cherrypick-robot commented Jan 23, 2020

Uh oh!

openshift-cherrypick-robot commented Jan 23, 2020

Uh oh!

vikram-redhat commented Jan 23, 2020

Uh oh!

rh-max commented Jan 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants