Skip to content

Add egress firewall docs for OVN-Kubernetes [4.6]#20719

Merged
jboxman merged 1 commit intoopenshift:masterfrom
jboxman-rh:OSDOCS-976
Sep 23, 2020
Merged

Add egress firewall docs for OVN-Kubernetes [4.6]#20719
jboxman merged 1 commit intoopenshift:masterfrom
jboxman-rh:OSDOCS-976

Conversation

@jboxman jboxman added this to the Future Release milestone Mar 27, 2020
@jboxman jboxman self-assigned this Mar 27, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@jboxman jboxman changed the title Add egress firewall docs for OVN-Kubernetes Add egress firewall docs for OVN-Kubernetes [4.5] Mar 30, 2020
@jboxman jboxman changed the title Add egress firewall docs for OVN-Kubernetes [4.5] Add egress firewall docs for OVN-Kubernetes [4.6] Apr 21, 2020
@jboxman jboxman modified the milestones: Future Release, Next Release Jun 2, 2020
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2020
@jboxman jboxman modified the milestones: Next Release, Future Release Jul 28, 2020
@jboxman jboxman force-pushed the OSDOCS-976 branch 7 times, most recently from 1e25de6 to e22d273 Compare August 4, 2020 01:34
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2020
@jboxman
Copy link
Contributor Author

jboxman commented Aug 27, 2020

@JacobTanenbaum, I've updated this to exclude DNS for OVN-Kubernetes only; Can you look and confirm whether the docs are accurate for OVN-Kubernetes?

Thanks!

@jboxman
Copy link
Contributor Author

jboxman commented Aug 31, 2020

Hi @huiran0826,

Can you verify the changes to the egress firewall documentation for OVN-Kubernetes?

Thanks!

@jboxman
Copy link
Contributor Author

jboxman commented Sep 1, 2020

@huiran0826 thank you!

@jboxman
Copy link
Contributor Author

jboxman commented Sep 1, 2020

@JacobTanenbaum, can you PTAL? Thanks!

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2020
@jboxman
Copy link
Contributor Author

jboxman commented Sep 4, 2020

@huiran0826, updated!

@jboxman jboxman added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 14, 2020
@adellape adellape self-requested a review September 14, 2020 21:05
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nits.

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 15, 2020
@jboxman
Copy link
Contributor Author

jboxman commented Sep 15, 2020

@adellape, thanks!

@huiran0826
Copy link

@jboxman After create the egressfirewall, the output should be "egressfirewall.k8s.ovn.org/default created
" , not "egressfirewall.network.openshift.io/default created"

@jboxman jboxman force-pushed the OSDOCS-976 branch 2 times, most recently from f1c9bd5 to 76e6844 Compare September 23, 2020 01:31
@jboxman jboxman merged commit 8ab1fdf into openshift:master Sep 23, 2020
@jboxman jboxman deleted the OSDOCS-976 branch September 23, 2020 01:59
@jboxman
Copy link
Contributor Author

jboxman commented Sep 23, 2020

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@jboxman: #20719 failed to apply on top of branch "enterprise-4.6":

Applying: Add egress firewall docs for OVN-Kubernetes
Using index info to reconstruct a base tree...
M	_topic_map.yml
A	_unused_topics/nw-egressnetworkpolicy-view.adoc
M	modules/nw-egressnetworkpolicy-about.adoc
Falling back to patching base and 3-way merge...
CONFLICT (rename/delete): _unused_topics/nw-egressnetworkpolicy-view.adoc deleted in Add egress firewall docs for OVN-Kubernetes and renamed to modules/nw-egressnetworkpolicy-view.adoc in HEAD. Version HEAD of modules/nw-egressnetworkpolicy-view.adoc left in tree.
Auto-merging modules/nw-egressnetworkpolicy-about.adoc
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add egress firewall docs for OVN-Kubernetes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants