OSDOCS-1086: Adding docs for graceful shutdown and restart by bergerhoffer · Pull Request #23028 · openshift/openshift-docs

bergerhoffer · 2020-06-18T15:46:53Z

https://issues.redhat.com/browse/OSDOCS-1086

Preview: https://osdocs-1086-shutdown--ocpdocs.netlify.app/openshift-enterprise/latest/backup_and_restore/graceful-cluster-shutdown.html

openshift-docs-preview-bot · 2020-06-18T15:51:23Z

The preview will be available shortly at:

https://OSDOCS-1086-shutdown--ocpdocs.netlify.com/

vareti · 2020-06-25T19:05:16Z

/lgtm

bergerhoffer · 2020-06-26T00:23:54Z

@xingxingxia @rpattath I believe that this is ready for QE review whenever you are ready. Though I believe there is still some testing of a 30 day shutdown that needs to be done, it would still be good to have this ready for whenever that is complete. Let me know if you have any questions for feedback, thanks!

Preview:

xingxingxia · 2020-06-30T11:00:48Z

modules/graceful-restart.adoc

If the worker nodes

This sentence seems not only applies worker nodes, applies to master nodes as well.

Good point. @vareti @sttts Is there a chance that the master nodes will need to have CSRs approved before they become ready? Like, that we need to add the steps to check for and approve CSRs for the masters to step 3?

https://osdocs-1086-shutdown--ocpdocs.netlify.app/openshift-enterprise/latest/backup_and_restore/graceful-cluster-restart.html#graceful-restart_graceful-restart-cluster

@xingxingxia is right. I just came to know that it is possible. We need to add similar steps to check CSR for master nodes too.

xingxingxia · 2020-06-30T11:02:26Z

Looks good from my side with a minor comment inline.

rpattath · 2020-06-30T20:39:07Z

LGTM

modules/graceful-shutdown.adoc

bergerhoffer · 2020-07-01T21:07:17Z

@xingxingxia @sttts @vareti I've updated to include the CSR approval steps for master nodes, and to add a note on draining (requested by https://bugzilla.redhat.com/show_bug.cgi?id=1802836#c12).

Can you all please take another look?

vareti · 2020-07-01T21:13:17Z

looks good.

xingxingxia · 2020-07-02T02:37:32Z

/lgtm

lamek

This looks great.

One thought - should we include a note or a line about what to do in the event that you cannot connect with oc after restarting your nodes?
https://github.com/openshift/openshift-docs/pull/23028/files#diff-9a3b0516c75db5c1a3fd397b561723eaR25

bergerhoffer · 2020-07-06T17:50:43Z

This looks great.

One thought - should we include a note or a line about what to do in the event that you cannot connect with oc after restarting your nodes?
https://github.com/openshift/openshift-docs/pull/23028/files#diff-9a3b0516c75db5c1a3fd397b561723eaR25

@vareti @sttts Is this something that a user might run into that we should provide guidance for?

vareti · 2020-07-06T18:44:33Z

Is this something that a user might run into that we should provide guidance for?

@bergerhoffer isn't that what we are saying here?

bergerhoffer · 2020-07-07T17:11:42Z

Is this something that a user might run into that we should provide guidance for?

@bergerhoffer isn't that what we are saying here?

Yes that's true, I forgot about that. That should be sufficient then, thanks!

bergerhoffer · 2020-07-16T12:49:29Z

Hi @xingxingxia @rpattath, can you let me know where we are with finalizing testing for this? I believe we were waiting on testing of a 30 day shutdown, but I wasn't sure how close we were to this. Thanks!

xingxingxia · 2020-07-17T03:31:38Z

I already replied in https://issues.redhat.com/browse/OSDOCS-1086 comments, waiting for Roshni's feedback.

bergerhoffer · 2020-07-28T13:34:07Z

Hi @rpattath - are there any updates on this?

bergerhoffer · 2020-08-03T20:27:28Z

QE approval received in Jira, merging!

bergerhoffer · 2020-08-03T20:27:45Z

/cherrypick enterprise-4.6

bergerhoffer · 2020-08-03T20:27:50Z

/cherrypick enterprise-4.5

openshift-cherrypick-robot · 2020-08-03T20:27:56Z

@bergerhoffer: new pull request created: #24435

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-08-03T20:28:00Z

@bergerhoffer: new pull request created: #24436

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bergerhoffer added the branch/enterprise-4.5 label Jun 18, 2020

bergerhoffer added this to the Future Release milestone Jun 18, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2020

bergerhoffer force-pushed the OSDOCS-1086-shutdown branch 5 times, most recently from fbccfcb to 3946092 Compare June 25, 2020 15:45

openshift-ci-robot assigned vareti Jun 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020

xingxingxia reviewed Jun 30, 2020

View reviewed changes

bergerhoffer force-pushed the OSDOCS-1086-shutdown branch from 3946092 to c1356eb Compare July 1, 2020 14:44

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 1, 2020

sttts reviewed Jul 1, 2020

View reviewed changes

modules/graceful-shutdown.adoc Outdated Show resolved Hide resolved

bergerhoffer force-pushed the OSDOCS-1086-shutdown branch 2 times, most recently from c66a419 to 4421ec5 Compare July 1, 2020 15:27

OSDOCS-1086: Adding docs for graceful shutdown and restart

5861da2

bergerhoffer force-pushed the OSDOCS-1086-shutdown branch from 4421ec5 to 5861da2 Compare July 1, 2020 20:46

bergerhoffer added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 1, 2020

openshift-ci-robot assigned xingxingxia Jul 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020

lamek reviewed Jul 2, 2020

View reviewed changes

bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 7, 2020

vikram-redhat added the branch/enterprise-4.6 label Jul 13, 2020

vikram-redhat modified the milestones: Future Release, Next Release Jul 13, 2020

bergerhoffer mentioned this pull request Aug 3, 2020

OSDOCS-1086: Adding shutdown restart to release notes #24434

Merged

bergerhoffer changed the title ~~[WIP] OSDOCS-1086: Adding docs for graceful shutdown and restart~~ OSDOCS-1086: Adding docs for graceful shutdown and restart Aug 3, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2020

bergerhoffer merged commit c5ad10e into openshift:master Aug 3, 2020

openshift-cherrypick-robot mentioned this pull request Aug 3, 2020

[enterprise-4.6] OSDOCS-1086: Adding docs for graceful shutdown and restart #24435

Merged

openshift-cherrypick-robot mentioned this pull request Aug 3, 2020

[enterprise-4.5] OSDOCS-1086: Adding docs for graceful shutdown and restart #24436

Merged

bergerhoffer deleted the OSDOCS-1086-shutdown branch October 29, 2020 14:42

Conversation

bergerhoffer commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-docs-preview-bot commented Jun 18, 2020

Uh oh!

vareti commented Jun 25, 2020

Uh oh!

bergerhoffer commented Jun 26, 2020

Uh oh!

xingxingxia Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergerhoffer Jul 1, 2020

Choose a reason for hiding this comment

Uh oh!

vareti Jul 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xingxingxia commented Jun 30, 2020

Uh oh!

rpattath commented Jun 30, 2020

Uh oh!

Uh oh!

bergerhoffer commented Jul 1, 2020

Uh oh!

vareti commented Jul 1, 2020

Uh oh!

xingxingxia commented Jul 2, 2020

Uh oh!

lamek left a comment

Choose a reason for hiding this comment

Uh oh!

bergerhoffer commented Jul 6, 2020

Uh oh!

vareti commented Jul 6, 2020

Uh oh!

bergerhoffer commented Jul 7, 2020

Uh oh!

bergerhoffer commented Jul 16, 2020

Uh oh!

xingxingxia commented Jul 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bergerhoffer commented Jul 28, 2020

Uh oh!

bergerhoffer commented Aug 3, 2020

Uh oh!

bergerhoffer commented Aug 3, 2020

Uh oh!

bergerhoffer commented Aug 3, 2020

Uh oh!

openshift-cherrypick-robot commented Aug 3, 2020

Uh oh!

openshift-cherrypick-robot commented Aug 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

bergerhoffer commented Jun 18, 2020 •

edited

Loading

xingxingxia Jun 30, 2020 •

edited

Loading

vareti Jul 1, 2020 •

edited

Loading

xingxingxia commented Jul 17, 2020 •

edited

Loading