Initial commit for IPI bare metal installation for OCP 4.6#25812
Conversation
|
The preview will be available shortly at: |
|
@johnwilkins I was checking and the PR seems to miss some of the things we recently covered in upstream: As well as lot of the conditionals we used to have the same source for several releases of the docs, I'm still reviewing how does applying this hilights as changes with upstream, thanks for the pointer |
3bd437e to
0fca139
Compare
There was a problem hiding this comment.
unnecessary line break before out-of-band?
There was a problem hiding this comment.
s/OpenShift Container Platform/{product-title}
modules/ipi-install-modifying-install-config-for-no-provisioning-network.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Need it there, because it's still named master in the software. I've informed Roger about this.
There was a problem hiding this comment.
Ibid, we need to maintain master in certain cases. The config file examples will have it until we get rid of it in the software. So I've made it parenthetical to de-emphasize it.
c11bf81 to
16dc13e
Compare
|
/cherrypick enterprise-4.6 |
|
@ahardin-rh: #25812 failed to apply on top of branch "enterprise-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| [id="ipi-install-configuration-files"] | ||
| = Configuration files | ||
| :context: ipi-install-configuration-files | ||
| :release: 4.6 |
There was a problem hiding this comment.
Hey @johnwilkins - what is the use of this attribute here? Unless I am misunderstanding, AsciiBinder provides the current version using the product-version attribute.
There was a problem hiding this comment.
@vikram-redhat in baremetal-deploy we use that value to define the version as we do use one set of docs for all releases and we use it in conditionals inside the code to show/hide the relevant sections
There was a problem hiding this comment.
Hi @iranzo - within OpenShift docs, you don't need this attribute. Instead use {product-version} wherever you want to use this and that will return, in the case of these docs, 4.6 and you can use that for conditionals like you would normally.


@ahardin-rh This is for the 4.6 release. I have not modified the topic map file yet.
@rlopez133 New topics for 4.6 to port back to upstream.
@iranzo See above.
Signed-off-by: John Wilkins jowilkin@redhat.com