Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
The preview will be available shortly at: |
abrennan89
force-pushed
the
knchannels
branch
from
4525db4 to
0424035
Compare
openshift-ci-robot
added
size/L
abrennan89
force-pushed
the
knchannels
branch
5 times, most recently
from
a702fdf to
cce7c6a
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
rhuss
left a comment
rhuss
left a comment
There was a problem hiding this comment.
Looks good mostly, I have some comments about some things that could maybe need some more clarification.
As mentioned I'm not sure whether there is already documentation about the kn configuration file and how you eg. can define sink prefixes within it. If so, we should also add how to define channel prefixes.
There was a problem hiding this comment.
I think we have also the possibility to define prefixes on our own in the configuration file (is this correct @navidshaikh ?), plus there is one predefined prefix imc: for an InMemoryChannel.
@abrennan89 do we already have a section where we describe the configuration file for kn ? If yes, I would add this, if not, we need a JIRA for adding this to the docs, too. I can deliver draft input for this.
There was a problem hiding this comment.
Maybe we should also explain what happens when now type is given: In this case a default type is selected which is configured clusterwide.
There was a problem hiding this comment.
I wonder where we should add that <GVK>: is optional (could be also a prefix like imc:), and if not given (as in the example below), then the default channel is used ?
There was a problem hiding this comment.
I think a reference which describes the sink prefix (which can also be optional) would be very helpful here.
|
We will follow up Roland's comments and more in depth prefix docs in the CLI reference guide work. |
bobfuru
left a comment
bobfuru
left a comment
There was a problem hiding this comment.
A few comments and otherwise LGTM!
bobfuru
added
the
peer-review-done
abrennan89
force-pushed
the
knchannels
branch
from
cce7c6a to
1c413c6
Compare
|
New changes are detected. LGTM label has been removed. |
abrennan89
force-pushed
the
knchannels
branch
from
1c413c6 to
7c2293c
Compare
abrennan89
force-pushed
the
knchannels
branch
from
a7e69e9 to
222c49e
Compare
abrennan89
left a comment
abrennan89
left a comment
There was a problem hiding this comment.
Thanks @bobfuru - should be up to date now.
I've commented out the sections that are for 1.11.0 (due in Nov) so this is OK to merge once the docs freeze is over.
This is for 4.6 only.
bobfuru
added
serverless
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.7 |
|
@bobfuru: new pull request created: #26786 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bobfuru: new pull request created: #26787 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Preview link: https://knchannels--ocpdocs.netlify.app/openshift-enterprise/latest/serverless/event_workflows/serverless-channels.html
CP to 4.6+