Terminology style updates for odo and helm#27428
Terminology style updates for odo and helm#27428bergerhoffer merged 1 commit intoopenshift:masterfrom
Conversation
|
@boczkowska @Preeticp I made the updates to the helm and odo CLI docs for our new style guidelines. I also fixed anything else I saw while I was reviewing. Can you please review these updates to make sure that these changes are okay? Thanks! |
|
The preview will be available shortly at: |
5e8c6d2 to
4a966cc
Compare
|
@Preeticp I also tried to start going through the pipelines tkn docs, but there are a lot of pipeline terms that I'm not sure what should be done for them: Pipeline/PipelineRun/Task/TaskRun/Condition/Pipeline Resources/Resource/ClusterTask/EventListener Can these terms follow our general term guidance, for example "task run"/"cluster task", etc.? Or at the very least, I assume that they are objects and should be styled as |
yhontyk
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM.
modules/helm-installing-helm.adoc
Outdated
There was a problem hiding this comment.
Is there a reason to change the CLI prompt here? There is no need to run this command with admin rights.
There was a problem hiding this comment.
@boczkowska I did this because the earlier steps in this procedure are all run using the "#" prompt, and there weren't any steps to switch back to a normal user or anything before running this command.
Are you okay with this change, or would you like me to revert these ones?
There was a problem hiding this comment.
It doesn't really matter if this particular command is run with admin rights or not, so I'd leave $
Hmm, I don't think we need to explicitly specify how to run commands as a superuser (sudo, su etc), it's developer-facing documentation in the end, but I can add instructions obviously.
There was a problem hiding this comment.
Okay, I'll go ahead and revert it then, thanks.
modules/helm-installing-helm.adoc
Outdated
Preeticp
left a comment
There was a problem hiding this comment.
@bergerhoffer apologies for the delay.
Looks good to me except for the question raised by Yana, on the change from $ to #
|
@bergerhoffer I will fix the changes for Pipelines CLI too. We have a Jira issue to track the effort and will plan it into our sprints. Meanwhile, I am updating them as I work on some of the Pipelines PR but this content is currently in the core Pipelines bucket. |
4a966cc to
ab4efc2
Compare
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.5 |
|
@bergerhoffer: new pull request created: #27868 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.4 |
|
@bergerhoffer: #27428 failed to apply on top of branch "enterprise-4.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: new pull request created: #27869 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: #27428 failed to apply on top of branch "enterprise-4.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.