Skip to content

Trigger doc updates#27493

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
Preeticp:trigger_mods
Nov 30, 2020
Merged

Trigger doc updates#27493
ahardin-rh merged 1 commit intoopenshift:masterfrom
Preeticp:trigger_mods

Conversation

@Preeticp
Copy link
Contributor

@Preeticp Preeticp commented Nov 18, 2020 •
edited
Loading

  • This PR updates the docs with the new Triggers CRD information and adds it to the workflow.
  • Styles for CRDs in the whole book will be updated through another PR. For now, I have tried to update them where possible.
  • A new attribute for release version was added in code snippets and RPMs were updated
    This has been reviewed by the QE.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Nov 18, 2020

The preview will be available shortly at:

savitaashture
savitaashture reviewed Nov 19, 2020
View reviewed changes
savitaashture
savitaashture reviewed Nov 19, 2020
View reviewed changes
ppitonak
ppitonak suggested changes Nov 19, 2020
View reviewed changes
@Preeticp
Copy link
Contributor Author

Preeticp commented Nov 22, 2020 •
edited
Loading

@ppitonak can you please take a look at the PR again? I have updated the Trigger Template descriptions, please let me know if anything needs to be modified. I have also made changes for the branch and RPMs PTAL. Thank you!!
Please note I will delete the conditions commands from the CLI section post confirmation from Pradeep and Vincent, through another PR

Preeticp
Preeticp commented Nov 23, 2020
View reviewed changes
Preeticp
Preeticp commented Nov 23, 2020
View reviewed changes
Preeticp
Preeticp commented Nov 23, 2020
View reviewed changes
ppitonak
ppitonak suggested changes Nov 23, 2020
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old branch is still used in
https://trigger_mods--ocpdocs.netlify.app/openshift-enterprise/latest/pipelines/creating-applications-with-cicd-pipelines.html#specifying-pvc-as-volumesource-in-workspaces_creating-applications-with-cicd-pipelines

@Preeticp
Copy link
Contributor Author

Preeticp commented Nov 24, 2020

@ppitonak as part of PR #27151 I am removing the Specifying PVC volume source module, see here: https://github.com/openshift/openshift-docs/pull/27151/files#diff-90f9986da05edabf86eee64980c7a3212bab465d962ce2fb40d2cdc1bdd1a98aL39
That will be merged before this and I will rebase this PR on top of that. That would fix the Old branch is still used in https://trigger_mods--ocpdocs.netlify.app/openshift-enterprise/latest/pipelines/creating-applications-with-cicd-pipelines.html#specifying-pvc-as-volumesource-in-workspaces_creating-applications-with-cicd-pipelines

@Preeticp Preeticp changed the title [WIP] Trigger doc updates Trigger doc updates Nov 30, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2020
ppitonak
ppitonak suggested changes Nov 30, 2020
View reviewed changes
ppitonak
ppitonak approved these changes Nov 30, 2020
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
ahardin-rh
ahardin-rh reviewed Nov 30, 2020
View reviewed changes
ahardin-rh
ahardin-rh reviewed Nov 30, 2020
View reviewed changes
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Nov 30, 2020

@Preeticp Looks great! Just a minor style suggestion from me. Once that is addressed and your commits are squashed down into one commit, this should be ready to go! What versions does it apply to? Thanks!

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 30, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2020

New changes are detected. LGTM label has been removed.

@Preeticp
Trigger doc updates
662cf8e 
triger template description changes and release branch changes

rpm updates

clarification on trigger template and pipeline run creation

attributes and typo

replacing with version attribute

attribute label

build fix

attribute changes

attribute and build

attribute fixes

removing callouts

review fixes
@Preeticp
Copy link
Contributor Author

Preeticp commented Nov 30, 2020

Thank you, @ahardin-rh, I fixed the styles, PTAL.
This needs to be merged to 4.6 and later.

@ahardin-rh ahardin-rh merged commit 50e2c48 into openshift:master Nov 30, 2020
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Nov 30, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 30, 2020
Merged
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Nov 30, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 30, 2020 •
edited by openshift-ci-robot
Loading

@ahardin-rh: new pull request created: #27711

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 30, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 30, 2020 •
edited by openshift-ci-robot
Loading

@ahardin-rh: new pull request created: #27712

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

+2 more reviewers

@savitaashture savitaashture savitaashture left review comments

@ppitonak ppitonak ppitonak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ppitonak ppitonak

Labels

branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Preeticp @openshift-docs-preview-bot @ahardin-rh @openshift-ci-robot @openshift-cherrypick-robot @ppitonak @savitaashture