Skip to content

Note that the MachineConfig for infra nodes is optional.#28384

Merged
codyhoag merged 1 commit intoopenshift:masterfrom
briantward:optional-infra-machineconfig
Jan 9, 2021
Merged

Note that the MachineConfig for infra nodes is optional.#28384
codyhoag merged 1 commit intoopenshift:masterfrom
briantward:optional-infra-machineconfig

Conversation

@briantward
Copy link

As noted in here, this step is optional. Customers really shouldn't and don't need to do this. It is, however, informative as to how MachineConfigs and MachingConfigPools are related.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2021
@codyhoag codyhoag added this to the Next Release milestone Jan 6, 2021
@codyhoag codyhoag self-requested a review January 6, 2021 15:12
Copy link
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits; I'll have QE sign off and then I'll merge it. Thanks!

@codyhoag
Copy link
Contributor

codyhoag commented Jan 6, 2021

@sunzhaohua2 can you confirm? Thanks!

@sunzhaohua2
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@codyhoag
Copy link
Contributor

codyhoag commented Jan 8, 2021

@briantward can you squash the commits? I'll merge once that is done. Thanks!

Update modules/creating-infra-machines.adoc
Co-authored-by: Cody Hoag <choag@redhat.com>
@briantward briantward force-pushed the optional-infra-machineconfig branch from 45e3cb7 to 71518d0 Compare January 8, 2021 21:59
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@briantward
Copy link
Author

@codyhoag squashed.

@codyhoag codyhoag merged commit 7aed0f5 into openshift:master Jan 9, 2021
@codyhoag
Copy link
Contributor

codyhoag commented Jan 9, 2021

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor

codyhoag commented Jan 9, 2021

/cherrypick enterprise-4.6

@codyhoag
Copy link
Contributor

codyhoag commented Jan 9, 2021

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 9, 2021

@codyhoag: new pull request created: #28475

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 9, 2021

@codyhoag: new pull request created: #28476

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 9, 2021

@codyhoag: new pull request created: #28477

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants