Note that the MachineConfig for infra nodes is optional.#28384
Note that the MachineConfig for infra nodes is optional.#28384codyhoag merged 1 commit intoopenshift:masterfrom
Conversation
codyhoag
left a comment
There was a problem hiding this comment.
Just a couple nits; I'll have QE sign off and then I'll merge it. Thanks!
|
@sunzhaohua2 can you confirm? Thanks! |
|
/lgtm |
|
@briantward can you squash the commits? I'll merge once that is done. Thanks! |
Update modules/creating-infra-machines.adoc Co-authored-by: Cody Hoag <choag@redhat.com>
45e3cb7 to
71518d0
Compare
|
New changes are detected. LGTM label has been removed. |
|
@codyhoag squashed. |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.5 |
|
@codyhoag: new pull request created: #28475 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@codyhoag: new pull request created: #28476 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@codyhoag: new pull request created: #28477 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As noted in here, this step is optional. Customers really shouldn't and don't need to do this. It is, however, informative as to how MachineConfigs and MachingConfigPools are related.