Web terminal docs#28480
Conversation
|
The preview will be available shortly at: |
|
@gajanan-more, @sleshchenko @abhinandan13jan @sahil143 can you please review this PR. Thank you. |
|
@gajanan-more, @sleshchenko, @JPinkney I have made changes as per the review comments. PTAL and let me know if any other changes are required. If no further changes are required, request you to add a LGTM. Thank you! |
jeana-redhat
left a comment
There was a problem hiding this comment.
Left a few suggestions, please reach out with any questions. Overall looking great!
|
Deploy preview for osdocs ready! Built with commit a04cc64 |
|
@jeana-redhat thank you for the review!! Another thing worth discussing is (though I have made the change) usage of this symbol for navigation between menus: '->' |
jeana-redhat
left a comment
There was a problem hiding this comment.
The new output uncovered a couple command lines that were missing their $ prompt. Otherwise looks great! Lmk when you have those done and re-squashed and I can help get it published 👍
removed bold from heading review edits review edits 2 image tag edit review edits first part review edits 2 minor fix review fix 3
|
Hey Preeti, I totally missed this comment - sorry! Wasn't ignoring your questions on purpose.
I landed on masthead after chatting a bit with @ahardin-rh, and finding it used in docs here. "Header" is not used in this sense in the docs, but I see where you found it in the IBM style guide (p. 233, "Select an action from the menu bar on the header." - good find!). So maybe "the menu bar on the header" is what we should use in general. @ahardin-rh - thoughts? Do we need to bring this up or just go ahead and defer to the ISG here and maybe update that instance of masthead?
I can't speak to the history of this decision, but I do know that using |
|
No worries, Jeana. |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.5 |
|
@jeana-redhat: new pull request created: #28911 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jeana-redhat: new pull request created: #28912 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jeana-redhat: new pull request created: #28913 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds docs for web terminal in Web Console.
This PR applies to 4.5, 4.6, and 4.7
Preview here: https://wto--ocpdocs.netlify.app/openshift-enterprise/latest/web_console/odc-about-web-terminal.html