[OSSMDOC-224] instructions on how to set the minimum and maximum protocol versions is incorrect#28904
Conversation
|
Deploy preview for osdocs ready! Built with commit 20d4303 |
|
@rcernich, could you please review this configuration? I think we probably need to update this entire topic for SMCP2.0, not just this code example. |
|
@JStickler Since this documentation is for SMCP 1.1 the values are correct as they stand. The real issue is that @jritter tried to use them on SMCP 2.0 which would obviously not work so I think your comment about updating this for 2.0 is the correct solution. |
knrc
left a comment
There was a problem hiding this comment.
Should not be merged as this stands, this needs to augment the existing 1.1 content with 2.0 content rather than replace it.
|
/cherry-pick enterprise-4.6 |
|
@JStickler: new pull request created: #30583 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.7 |
|
@JStickler: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.6 from head openshift-cherrypick-robot:cherry-pick-28904-to-enterprise-4.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-28904-to-enterprise-4.6."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.8 |
|
@JStickler: new pull request created: #30585 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JStickler: new pull request created: #30587 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Configuring the ServiceMeshControlPlane object according to the documentation does not work, the documentation specifies incorrect keys.
Fixes https://issues.redhat.com/browse/OSSMDOC-224