Skip to content

GH#28357 - Clarify selectors for EgressIP objects#29426

Merged
jboxman merged 1 commit intoopenshift:masterfrom
jboxman-rh:gh-28357
Mar 16, 2021
Merged

GH#28357 - Clarify selectors for EgressIP objects#29426
jboxman merged 1 commit intoopenshift:masterfrom
jboxman-rh:gh-28357

Conversation

@jboxman
Copy link
Contributor

@jboxman jboxman commented Feb 11, 2021

Clarify the language, fix typos, and improve presentation.

Preview:

Refs: #28357

@netlify
Copy link

netlify bot commented Feb 11, 2021

Deploy preview for osdocs ready!

Built with commit 45ff848

https://deploy-preview-29426--osdocs.netlify.app

@jboxman jboxman changed the title Clarify selectors for EgressIP objects GH#28357 - Clarify selectors for EgressIP objects Feb 11, 2021
@jboxman
Copy link
Contributor Author

jboxman commented Feb 19, 2021

@huiran0826, does this look okay? Thanks!

@jboxman
Copy link
Contributor Author

jboxman commented Feb 19, 2021

@alexanderConstantinescu, I've tried to clarify how selectors work in this PR. What do you think? Thanks!

@huiran0826
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@jboxman
Copy link
Contributor Author

jboxman commented Mar 1, 2021

@alexanderConstantinescu, I've updated the comment; I think it is still correct, but it's been awhile since I've written about this, so it's possible it isn't. Can you confirm? Thanks!

@jboxman jboxman added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 1, 2021
@alexanderConstantinescu
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2021
@jboxman
Copy link
Contributor Author

jboxman commented Mar 5, 2021

@alexanderConstantinescu, although in the diagram, only pods from namespace 1 actually egress. namespace 2 is not selected in the diagram. So that's why it was in its original form, I realize now. I'll have to consider what to do next.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
@jboxman
Copy link
Contributor Author

jboxman commented Mar 9, 2021

@huiran0826 can you verify this? Thanks!

@huiran0826
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 9, 2021
@jboxman
Copy link
Contributor Author

jboxman commented Mar 16, 2021

@bergerhoffer thanks!

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@jboxman jboxman merged commit fa71cf9 into openshift:master Mar 16, 2021
@jboxman jboxman deleted the gh-28357 branch March 16, 2021 04:14
@jboxman
Copy link
Contributor Author

jboxman commented Mar 16, 2021

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot

@jboxman: new pull request created: #30504

Details

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman
Copy link
Contributor Author

jboxman commented Mar 16, 2021

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot

@jboxman: new pull request created: #30505

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman
Copy link
Contributor Author

jboxman commented Mar 16, 2021

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@jboxman: new pull request created: #30506

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman
Copy link
Contributor Author

jboxman commented Mar 16, 2021

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot

@jboxman: #29426 failed to apply on top of branch "enterprise-4.5":

Applying: Clarify selectors for EgressIP objects
Using index info to reconstruct a base tree...
M	modules/nw-egress-ips-about.adoc
A	modules/nw-egress-ips-assign.adoc
A	modules/nw-egress-ips-object.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/nw-egress-ips-object.adoc deleted in HEAD and modified in Clarify selectors for EgressIP objects. Version Clarify selectors for EgressIP objects of modules/nw-egress-ips-object.adoc left in tree.
CONFLICT (modify/delete): modules/nw-egress-ips-assign.adoc deleted in HEAD and modified in Clarify selectors for EgressIP objects. Version Clarify selectors for EgressIP objects of modules/nw-egress-ips-assign.adoc left in tree.
Auto-merging modules/nw-egress-ips-about.adoc
CONFLICT (content): Merge conflict in modules/nw-egress-ips-about.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Clarify selectors for EgressIP objects
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants