GH#28357 - Clarify selectors for EgressIP objects#29426
GH#28357 - Clarify selectors for EgressIP objects#29426jboxman merged 1 commit intoopenshift:masterfrom
Conversation
|
Deploy preview for osdocs ready! Built with commit 45ff848 |
|
@huiran0826, does this look okay? Thanks! |
|
@alexanderConstantinescu, I've tried to clarify how selectors work in this PR. What do you think? Thanks! |
|
/lgtm |
|
@alexanderConstantinescu, I've updated the comment; I think it is still correct, but it's been awhile since I've written about this, so it's possible it isn't. Can you confirm? Thanks! |
|
/lgtm |
|
@alexanderConstantinescu, although in the diagram, only pods from namespace 1 actually egress. namespace 2 is not selected in the diagram. So that's why it was in its original form, I realize now. I'll have to consider what to do next. |
|
@huiran0826 can you verify this? Thanks! |
|
/lgtm |
bergerhoffer
left a comment
There was a problem hiding this comment.
Just a few suggestions
|
@bergerhoffer thanks! |
|
New changes are detected. LGTM label has been removed. |
|
/cherry-pick enterprise-4.8 |
|
@jboxman: new pull request created: #30504 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.7 |
|
@jboxman: new pull request created: #30505 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.6 |
|
@jboxman: new pull request created: #30506 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.5 |
|
@jboxman: #29426 failed to apply on top of branch "enterprise-4.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Clarify the language, fix typos, and improve presentation.
Preview:
Refs: #28357