Skip to content

GitHub issue-28150/issue-29904 update PVC command for registry#30776

Merged
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:GHissue-28150-29904
Apr 5, 2021
Merged

GitHub issue-28150/issue-29904 update PVC command for registry#30776
bmcelvee merged 1 commit intoopenshift:masterfrom
bmcelvee:GHissue-28150-29904

Conversation

@bmcelvee bmcelvee added branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 issue-burndown Indicates an issue worked on during an "GitHub Issue Burndown" session labels Mar 23, 2021
@bmcelvee bmcelvee added this to the Next Release milestone Mar 23, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2021
@netlify
Copy link

netlify bot commented Mar 23, 2021

Deploy preview for osdocs ready!

Built with commit 52d92cb

https://deploy-preview-30776--osdocs.netlify.app

@bmcelvee
Copy link
Contributor Author

Hi @duanwei33, would you mind reviewing this PR, please? It's an amendment to a PVC creation command. Thank you!

@bmcelvee
Copy link
Contributor Author

@openshift/team-documentation PTAL, thanks!

@bmcelvee bmcelvee added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 23, 2021
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but just checking whether this needs to be made back to 4.5 as well

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 23, 2021
@bmcelvee
Copy link
Contributor Author

Just a bump on this because it likely got lost in requests: Hi @duanwei33, would you mind reviewing this PR, please? It's an amendment to a PVC creation command. Thank you!

@duanwei33
Copy link

/LGTM
Sorry I missed the first mention @bmcelvee

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@bmcelvee bmcelvee merged commit 4a44c07 into openshift:master Apr 5, 2021
@bmcelvee
Copy link
Contributor Author

bmcelvee commented Apr 5, 2021

/cherrypick enterprise-4.5

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Apr 5, 2021

/cherrypick enterprise-4.6

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Apr 5, 2021

/cherrypick enterprise-4.7

@bmcelvee
Copy link
Contributor Author

bmcelvee commented Apr 5, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #31244

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #31245

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #31246

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #31247

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 issue-burndown Indicates an issue worked on during an "GitHub Issue Burndown" session lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enterprise-4.6] Issue in file registry/configuring_registry_storage/configuring-registry-storage-vsphere.adoc

5 participants