Conversation
|
Deploy preview for osdocs ready! Built with commit f37791b |
bergerhoffer
left a comment
There was a problem hiding this comment.
Actual changes look good, but have two additional pieces of feedback:
- I don't see in our guidelines that "Optional:" is preferred, though I remember talking about this, so I'm surprised that it's not. If we're asking people to use that over other ways, we should add it as a guideline. Would you mind doing that in a separate PR?
- I would backport this as far as possible, just to avoid future merge conflicts for others.
|
@bergerhoffer, from what I gather, this came from ISG and in the new edition appears on page 185. |
Awesome, I hadn't caught that in the update. That's good enough for me then, thanks! |
|
/cherry-pick enterprise-4.8 |
|
@jboxman: new pull request created: #30864 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.7 |
|
@jboxman: new pull request created: #30865 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.6 |
|
@jboxman: #30835 failed to apply on top of branch "enterprise-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Always use Optional:.