Skip to content

NTO: More precise description of MCP matching.#30905

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
jmencak:nto-docs-mcp-matching-clarify
Apr 6, 2021
Merged

NTO: More precise description of MCP matching.#30905
ahardin-rh merged 1 commit intoopenshift:masterfrom
jmencak:nto-docs-mcp-matching-clarify

Conversation

@jmencak
Copy link
Contributor

@jmencak jmencak commented Mar 25, 2021

The documentation was not precise when it came to two or more
MachineConfigPools with nodeSelector matching the same node(s). This
can happen (e.g. when a node has both master and worker role), but a
single node will always be assigned (a member of) only one or no
MachineConfigPool.

The documentation was not precise when it came to two or more
MachineConfigPools with nodeSelector matching the same node(s).  This
can happen (e.g. when a node has both master and worker role), but a
single node will always be assigned (a member of) only one or no
MachineConfigPool.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2021
@jmencak
Copy link
Contributor Author

jmencak commented Mar 25, 2021

/cc @ahardin-rh
It would be great if this clarification could go all the way down to 4.6.

@netlify
Copy link

netlify bot commented Mar 25, 2021

Deploy preview for osdocs ready!

Built with commit c16f796

https://deploy-preview-30905--osdocs.netlify.app

@jmencak
Copy link
Contributor Author

jmencak commented Mar 31, 2021

@skordas any chance you could provide QE review for this one? Thanks!

Copy link
Contributor

@ahardin-rh ahardin-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahardin-rh ahardin-rh assigned skordas and unassigned skordas Mar 31, 2021
@ahardin-rh ahardin-rh requested a review from skordas March 31, 2021 14:17
@skordas
Copy link

skordas commented Apr 6, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2021
@ahardin-rh ahardin-rh merged commit 922ec15 into openshift:master Apr 6, 2021
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.6

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #31299

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #31300

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #31301

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the nto-docs-mcp-matching-clarify branch April 6, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants