Skip to content

Revised config example#31680

Merged
adellape merged 1 commit intoopenshift:masterfrom
sabrinajess:1937663
Apr 21, 2021
Merged

Revised config example#31680
adellape merged 1 commit intoopenshift:masterfrom
sabrinajess:1937663

Conversation

@sabrinajess
Copy link
Contributor

@sabrinajess sabrinajess commented Apr 19, 2021

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 19, 2021
@netlify
Copy link

netlify bot commented Apr 19, 2021

Deploy preview for osdocs ready!

Built with commit 5e978c6

https://deploy-preview-31680--osdocs.netlify.app

@sabrinajess
Copy link
Contributor Author

@jeniferh Updated the fix, thanks for catching that. Please review.

@jeniferh
Copy link

LGTM!

Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible spot for an .Example output block title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added block title .Example configuration file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it doesn't show up in the rendered version, but did notice an extra blank line here in source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@adellape adellape added this to the Next Release milestone Apr 20, 2021
@adellape adellape added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 21, 2021
@adellape adellape merged commit ba684c4 into openshift:master Apr 21, 2021
@adellape
Copy link
Contributor

/cherrypick enterprise-4.8

@adellape
Copy link
Contributor

/cherrypick enterprise-4.7

@adellape
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@adellape: new pull request created: #31743

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #31744

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #31745

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants