TELCODOCS-309: BZ1995631 & BZ1999603 / 9/13 Fixed BZs also added to the 4.9 Release Notes#36228
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 10726c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6166fca2b4f7670007197b49 😎 Browse the preview: https://deploy-preview-36228--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes |
5e8d7b2 to
41d17b9
Compare
ctauchen
left a comment
There was a problem hiding this comment.
Thanks for this -- a few comments and suggestions for you below.
But first, some housekeeping:
Please remember to add a link to your preview content in your first PR comment. This helps the peer review squad find your builds quickly.
bobfuru
left a comment
There was a problem hiding this comment.
Added a couple of comments for consideration. Thanks!
jeana-redhat
left a comment
There was a problem hiding this comment.
In general, there are a handful of terms that I am unsure about. I would expect things like "baremetal-ipi" to be written out (bare metal on installer-provisioned infrastructure?), and things like "ironic-python-agent" to either be enclosed in backticks or written out. But I'm not familiar enough with the bare metal content to know for sure what to recommend - can you check the following against how they are used in the actual content where they are discussed?
- metal3 (I see both metal3 and Metal3 in the repo)
- InitContainers/InitContainer
- baremetal-ipi
- ironic-python-agent
- sushy library
- VirtualMedia.InsertMedia request body
- BareMetalHost
- cgroups
There was a problem hiding this comment.
| * Previously, metal3 pods could not download an RHCOS image due to the sequencing of creating InitContainers. This issue is fixed by reordering the creation of the initContainers, so that InitContainer `metal-static-ip-set` now happens prior to InitContainer `metal3-machine-os-downloader`. The RHCOS image now downloads as expected. | |
| * Previously, metal3 pods could not download an {op-system-first} image due to the sequencing of creating InitContainers. This issue is fixed by reordering the creation of the initContainers, so that InitContainer `metal-static-ip-set` now happens prior to InitContainer `metal3-machine-os-downloader`. The {op-system} image now downloads as expected. |
In this item InitContainers is capitalized as InitContainers and initContainers - I don't know which is correct but should probably be the same throughout :) I also see an instance of InitContainer (singular). If this is an API object we would typically say e.g. "InitContainer object" (sing) or "InitContainer objects" (plur) rather than making a plural of the object name. I don't know what they are in this context so please forgive me if this feedback is not relevant/helpful!
There was a problem hiding this comment.
Thanks for your feedback Jeana. Changing occurrences to 'initContainer' as used in the OCP docs https://docs.openshift.com/container-platform/4.8/rest_api/monitoring_apis/alertmanager-monitoring-coreos-com-v1.html . Thanks.
There was a problem hiding this comment.
I have also changed the instances of RHCOS to {op-system-first} / {op-system}. Thanks.
There was a problem hiding this comment.
Unsure about usage of "baremetal-ipi", see main review comment.
There was a problem hiding this comment.
Pardon the drive-by comment here but @jeana-redhat is correct in that we don't use the IPI (or UPI) shorthand in docs and should always spell out. For example, "Previously, when using installer-provisioned installation on bare metal with a host configured...."
There was a problem hiding this comment.
Thanks for your feedback Jeana / Bob. I have rewritten as Bob suggests. Thanks.
There was a problem hiding this comment.
Unsure about usage of "ironic-python-agent", see main review comment.
There was a problem hiding this comment.
Thanks for your feedback Jeana. This has been updated with backticks. Thanks.
There was a problem hiding this comment.
Unsure about usage of "metal3", see main review comment.
There was a problem hiding this comment.
Thanks for your feedback Jeana. 'metal3' is ok. It is already used in the OCP docs https://docs.openshift.com/container-platform/4.8/rest_api/provisioning_apis/provisioning-metal3-io-v1alpha1.html . Thanks.
There was a problem hiding this comment.
| * Previously, when a cluster with network policies was upgraded from version 4.5 to 4.6, old address sets were orphaned due to a naming convention change in 4.6. This resulted in network policies created in 4.5 with namespace selector criteria not working correctly in 4.6 or later releases. They did not work as they relied on matching old address sets that were not being kept updated with the pod IPs within such namespaces. This issue is fixed with an OVN-Kubernetes upgrade where address sets with old naming conventions are removed, and policies referencing these old address sets are updated, referencing the address sets following the new naming convention. | |
| (link:https://bugzilla.redhat.com/show_bug.cgi?id=1962387[*BZ#1962387*]) |
This bug showed up under "Networking" in our query and has already been added.
There was a problem hiding this comment.
You are correct Jeana. Alex pointed me to the 'The Release Notes 4.9 Bug Fix Summaries' excel and I see that 1962387 has already been added. I have removed me version of the text as it's best to align with this excel. I added the text as this BZ also showed up in a query I was using and I wasn't aware of the master excel. Thanks.
There was a problem hiding this comment.
| * Previously, when pods were created, and then quickly deleted, they were not cleaned up by the kubelet within 20 minutes. This impacted the availability of upgrades, and consequently, the users. This issue is fixed by improving the pod lifecyle logic within the kubelet. | |
| (link:https://bugzilla.redhat.com/show_bug.cgi?id=1952224[*BZ#1952224*]) |
This bug showed up under "Node" in our query and has already been added.
There was a problem hiding this comment.
You are correct Jeana. Alex pointed me to the 'The Release Notes 4.9 Bug Fix Summaries' excel and I see that 1952224 has already been added. I have removed me version of the text as it's best to align with this excel. I added the text as this BZ also showed up in a query I was using and I wasn't aware of the master excel. Thanks.
There was a problem hiding this comment.
Unsure about usage of "cgroups", see main review comment.
There was a problem hiding this comment.
Thanks for your feedback Jeana. This has been updated with backticks. Thanks.
There was a problem hiding this comment.
| * The `ip vrf exec` does not work due to a cgroups mismatch. As a result, this command cannot be used inside OpenShift pods. To use virtual routing and forwarding (VRF), applications must be VRF-aware and bind directly to the VRF interface. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1995631[*BZ#1995631*]) | |
| * The `ip vrf exec` command does not work due to a cgroups mismatch. As a result, this command cannot be used inside {product-title} pods. To use virtual routing and forwarding (VRF), applications must be VRF-aware and bind directly to the VRF interface. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1995631[*BZ#1995631*]) |
|
Thanks for your feedback Jeana. I have addressed you comments in the specific instances. Thanks. |
30e2bfb to
4617b0a
Compare
aireilly
left a comment
There was a problem hiding this comment.
A few small comments :)
There was a problem hiding this comment.
| * Previously, metal3 pods could not download an RHCOS image due to the sequencing of creating initContainers. This issue is fixed by reordering the creation of the initContainers, so that initContainer `metal-static-ip-set` now happens prior to initContainer `metal3-machine-os-downloader`. The RHCOS image now downloads as expected. | |
| * Previously, metal3 pods could not download an RHCOS image due to the sequencing of creating initContainers. This issue is fixed by reordering the creation of the initContainers, so that the `metal-static-ip-set` initContainer is created before the `metal3-machine-os-downloader` initContainer. The RHCOS image now downloads as expected. |
There was a problem hiding this comment.
Thanks for your feedback Aidan. I have applied your suggested update. Thanks.
There was a problem hiding this comment.
| * Previously, when using installer-provisioned installation on bare metal with a host configured to use `idrac-virtualmedia`, the `bios_interface` for that host got set to `idrac-wsman` by default. This resulted in the BIOS settings being unavailable and an exception occurring in the log files. This issue is fixed by using `idrac-redfish` for the default `bios_interface` when using `idrac-virtualmedia`. | |
| * Previously, when using installer-provisioned installation on bare metal with a host configured to use `idrac-virtualmedia`, the `bios_interface` for that host got set to `idrac-wsman` by default. This resulted in the BIOS settings being unavailable and an exception occurring. This issue is fixed by using `idrac-redfish` for the default `bios_interface` when using `idrac-virtualmedia`. |
Nit: the exception occurs in the course of application processing, and is recorded in the logs. It doesn't occur in the logs.
There was a problem hiding this comment.
Thanks for your feedback Aidan. I have applied your suggested update. Thanks.
There was a problem hiding this comment.
| * Previously, following a cluster node reboot, on network configurations specific to OVN-Kubernetes and using link aggregation, cluster network connectivity was lost. This issue is fixed by correctly persisting OVN-Kubernetes specific network configuration across reboots of the cluster nodes. | |
| * Previously, following a cluster node reboot, on network configurations specific to OVN-Kubernetes and using link aggregation, cluster network connectivity was lost. This issue is fixed by correctly persisting the OVN-Kubernetes specific network configuration across reboots of the cluster nodes. |
There was a problem hiding this comment.
Thanks for your feedback Aidan. I have applied your suggested update. Thanks.
There was a problem hiding this comment.
| * The `ip vrf exec` does not work due to a `cgroups` mismatch. As a result, this command cannot be used inside OpenShift pods. To use virtual routing and forwarding (VRF), applications must be VRF-aware and bind directly to the VRF interface. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1995631[*BZ#1995631*]) | |
| * The `ip vrf exec` command does not work due to a `cgroups` mismatch. As a result, this command cannot be used inside OpenShift pods. To use virtual routing and forwarding (VRF), applications must be VRF-aware and bind directly to the VRF interface. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1995631[*BZ#1995631*]) |
There was a problem hiding this comment.
Thanks for your feedback Aidan. I have applied your suggested update. Thanks.
4617b0a to
db7edd0
Compare
ctauchen
left a comment
There was a problem hiding this comment.
A few nits, as we're fond of saying.
There was a problem hiding this comment.
Thanks for your feedback Christopher. I have applied your suggested update. Thanks.
There was a problem hiding this comment.
| * Previously, some error types in the provisioned state caused the host to be deprovisioned. This occurred after a restart of the metal3 pod if the image provisioned to a Bare Metal Host became unavailable. In this case, the host would enter the deprovisioning state. This issue is fixed by modifying the action of the error in the provisioned state so that if the image becomes unavailable, the error will be reported but deprovisioning will not be initiated. | |
| * Previously, some error types in the provisioned state caused the host to be deprovisioned. This occurred after a restart of the metal3 pod if the image provisioned to a bare metal host became unavailable. In this case, the host would enter the deprovisioning state. This issue is fixed by modifying the action of the error in the provisioned state so that if the image becomes unavailable, the error will be reported but deprovisioning will not be initiated. |
There was a problem hiding this comment.
Thanks for your feedback Christopher. I have applied your suggested update. Thanks.
db7edd0 to
02b16fa
Compare
02b16fa to
42accb8
Compare
|
New changes are detected. LGTM label has been removed. |
…he 4.9 Release Notes
42accb8 to
10726c6
Compare
Applies only to the Enterprise-4.9 branch
https://issues.redhat.com/browse/TELCODOCS-309
Browse the preview for Known Issues: https://deploy-preview-36228--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes#ocp-4-9-known-issues
Browse the preview for Fixed Issues: https://deploy-preview-36228--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes#ocp-4-9-bug-fixes