Skip to content

RN: Addition of 4-9 RN file.#36236

Merged
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.9from
sabrinajess:RN49
Sep 14, 2021
Merged

RN: Addition of 4-9 RN file.#36236
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.9from
sabrinajess:RN49

Conversation

@sabrinajess
Copy link
Contributor

@sabrinajess sabrinajess commented Sep 9, 2021

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@sabrinajess sabrinajess changed the base branch from main to enterprise-4.9 September 9, 2021 17:39
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2021
@netlify
Copy link

netlify bot commented Sep 9, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 01e0fe0

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/613b8dd902574d0007587b8b

😎 Browse the preview: https://deploy-preview-36236--osdocs.netlify.app/openshift-enterprise/latest/virt/virt-4-9-release-notes

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2021
@sabrinajess sabrinajess changed the title Rn49 RN: Addition of 4-9 RN file. Sep 9, 2021
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2021
@ousleyp ousleyp added branch/enterprise-4.9 CNV Label for all CNV PRs labels Sep 10, 2021
@ousleyp ousleyp added this to the Future Release milestone Sep 10, 2021
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure it is on your radar, but just a couple of reminders about the Deprecated features and Technology Preview features sections.
The deprecated feature will be removed in 4.9, so you will need to delete that text and possibly the entire Deprecated features section if there are no other deprecated features.
Similarly, you will need to update the Technology Preview features section as well.

I can merge this PR if you want to tackle the above items and the Known issues updates in a separate PR.

* You can now xref:../virt/virtual_machines/virtual_disks/virt-hot-plugging-virtual-disks.adoc#virt-hot-plugging-virtual-disks[hot-plug and hot-unplug virtual disks] when you want to add or remove them from your virtual machine without stopping the virtual machine instance.

[id="virt-4-9-known-issues"]
== Known issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing you created this file off of the 4.8 release notes file but for some reason there is a discrepancy between the list of known issues published for 4.8 and what you have in here. You might want to give those a closer look.

@sjhala-ccs sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 13, 2021
@sabrinajess
Copy link
Contributor Author

@sjhala-ccs Please merge as-is. I’m saving updating the other sections for after this is merged since I expect those to take more time and I want to get the RN built for folks to add/update. Thanks for the notes so I don't forget it, too.

@sjhala-ccs sjhala-ccs merged commit ef4022c into openshift:enterprise-4.9 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants