Skip to content

added command oc label#37192

Merged
mikemckiernan merged 1 commit intoopenshift:mainfrom
Amrita42:Amrita-BZ1912719
Oct 12, 2021
Merged

added command oc label#37192
mikemckiernan merged 1 commit intoopenshift:mainfrom
Amrita42:Amrita-BZ1912719

Conversation

@Amrita42
Copy link
Contributor

@Amrita42 Amrita42 commented Oct 7, 2021

Applies to 4.7+ versions
https://bugzilla.redhat.com/show_bug.cgi?id=1912719

Added the oc label command and rephrased one step that says Run .
Preview:
https://deploy-preview-37192--osdocs.netlify.app/?utm_source=github&utm_campaign=bot_dp

@jianzhangbjz please review

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2021
@netlify
Copy link

netlify bot commented Oct 7, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c0ef3da

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61644390c369b80007689b64

😎 Browse the preview: https://deploy-preview-37192--osdocs.netlify.app

@stevsmit
Copy link
Member

stevsmit commented Oct 7, 2021

lgtm

@rioliu-rh
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2021
Copy link

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits. One-thousand thanks for replacing "Run". Please let me know what I can clarify.

@mikemckiernan mikemckiernan added this to the Next Release milestone Oct 11, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2021

New changes are detected. LGTM label has been removed.

@mikemckiernan mikemckiernan merged commit 2d05c43 into openshift:main Oct 12, 2021
@mikemckiernan
Copy link

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@mikemckiernan: #37192 failed to apply on top of branch "enterprise-4.9":

Applying: added command oc label
Using index info to reconstruct a base tree...
M	modules/create-a-kubeletconfig-crd-to-edit-kubelet-parameters.adoc
M	modules/modify-unavailable-workers.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/modify-unavailable-workers.adoc
CONFLICT (content): Merge conflict in modules/modify-unavailable-workers.adoc
Auto-merging modules/create-a-kubeletconfig-crd-to-edit-kubelet-parameters.adoc
CONFLICT (content): Merge conflict in modules/create-a-kubeletconfig-crd-to-edit-kubelet-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 added command oc label
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants