Skip to content

OSDOCS-3014: Add links to pruning for disconnected OLM#39340

Merged
adellape merged 1 commit intoopenshift:mainfrom
adellape:prune_link
Dec 2, 2021
Merged

OSDOCS-3014: Add links to pruning for disconnected OLM#39340
adellape merged 1 commit intoopenshift:mainfrom
adellape:prune_link

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Nov 29, 2021

https://issues.redhat.com/browse/OSDOCS-3014

  • Changed the name of the "Pruning a SQLite-based index image" section to Filtering a SQLite-based index image.
  • Updated the Prerequisites for "Mirroring Operator catalogs for use with disconnected clusters" to include links for what is needed if you want to prune/filter an index image before mirroring.
  • So that the links to the 2 required sections could be actual xrefs, I've removed the modules/olm-mirroring-catalog-prereqs.adoc file and pulled the prereqs inline into the installing/installing-mirroring-installation-images.adoc assembly proper (since we can't xref from modules).

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 29, 2021
@netlify
Copy link

netlify bot commented Nov 29, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 70ba2b328bea1298e211d5a167a0dd8e18468135

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a55cedbc2d0a00089491f8

😎 Browse the preview: https://deploy-preview-39340--osdocs.netlify.app/openshift-enterprise/latest/installing/installing-mirroring-installation-images

@netlify
Copy link

netlify bot commented Nov 29, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c3142a9

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a93ae532e75700074de59a

😎 Browse the preview: https://deploy-preview-39340--osdocs.netlify.app/openshift-enterprise/latest/installing/installing-mirroring-installation-images

@jianzhangbjz
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2021

New changes are detected. LGTM label has been removed.

@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 30, 2021
Copy link
Contributor

@sagidlow sagidlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions :) Let me know if you have any questions!

@sagidlow sagidlow added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 30, 2021
@adellape adellape merged commit f4eccd4 into openshift:main Dec 2, 2021
@adellape adellape deleted the prune_link branch December 2, 2021 21:33
@adellape
Copy link
Contributor Author

adellape commented Dec 2, 2021

/cherrypick enterprise-4.10

@adellape
Copy link
Contributor Author

adellape commented Dec 2, 2021

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@adellape: new pull request created: #39507

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #39508

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants