Skip to content

SRVCLI-325: Add docs on kn event #40880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abrennan89 merged 1 commit into from
Feb 3, 2022
Merged

SRVCLI-325: Add docs on kn event #40880

abrennan89 merged 1 commit into from
Feb 3, 2022

Conversation

@rh-max
Copy link
Contributor

@rh-max rh-max commented Jan 21, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2022
@netlify
Copy link

netlify bot commented Jan 21, 2022 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: d2b4d2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61fbee5a3f69030007293380

😎 Browse the preview: https://deploy-preview-40880--osdocs.netlify.app/openshift-enterprise/latest/serverless/reference/kn-event-ref

@rh-max
Copy link
Contributor Author

rh-max commented Jan 21, 2022

@cardil Could you PTAL?

cardil
cardil suggested changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor changes.

@rh-max
Copy link
Contributor Author

rh-max commented Jan 21, 2022

@mvinkler or @jrangelramos Could you PTAL?

jrangelramos
jrangelramos reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@jrangelramos jrangelramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment/suggestion. Otherwise it looks good.

jrangelramos
jrangelramos reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jrangelramos jrangelramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another minor suggestion.

@jrangelramos
Copy link
Contributor

jrangelramos commented Jan 25, 2022

QE Approved

@kmccarron-rh
Copy link
Contributor

kmccarron-rh commented Jan 25, 2022 •
edited
Loading

@rh-max Please reduce to 1 commit per this section of the guidelines: https://docs.google.com/document/d/1fLMpK4bqthtFlCwA36yeo2cI-pExFpX76VMnSi_In6Q/edit#heading=h.epes4xf06pzk

kmccarron-rh
kmccarron-rh reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@kmccarron-rh kmccarron-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit. This reads very well. The plural associated with the --field option gave me a brief moment of hesitation. I had to skipped down to the example to understand that you specify 1 f-v per option, but can specify multiple options.

jeana-redhat
jeana-redhat reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few thoughts

@jeana-redhat jeana-redhat added this to the Next Release milestone Jan 25, 2022
abrennan89
abrennan89 reviewed Feb 2, 2022
View reviewed changes
abrennan89
abrennan89 reviewed Feb 2, 2022
View reviewed changes
abrennan89
abrennan89 reviewed Feb 2, 2022
View reviewed changes
abrennan89
abrennan89 reviewed Feb 2, 2022
View reviewed changes
abrennan89
abrennan89 requested changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Tech preview module is missing.

@abrennan89 abrennan89 added the serverless Label for all Serverless PRs label Feb 3, 2022
@abrennan89 abrennan89 merged commit 19e0392 into openshift:main Feb 3, 2022
@abrennan89
Copy link
Contributor

abrennan89 commented Feb 3, 2022

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor

abrennan89 commented Feb 3, 2022

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor

abrennan89 commented Feb 3, 2022

/cherrypick enterprise-4.9

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2022

@abrennan89: new pull request created: #41368

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 3, 2022
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2022

@abrennan89: new pull request created: #41369

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

abrennan89 commented Feb 3, 2022

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 3, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2022

@abrennan89: new pull request created: #41370

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor

abrennan89 commented Feb 3, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 3, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2022

@abrennan89: new pull request created: #41371

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 3, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 3, 2022

@abrennan89: new pull request created: #41372

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

@abrennan89 abrennan89 abrennan89 requested changes

+3 more reviewers

@cardil cardil cardil requested changes

@jrangelramos jrangelramos jrangelramos left review comments

@kmccarron-rh kmccarron-rh kmccarron-rh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@rh-max @jrangelramos @kmccarron-rh @abrennan89 @openshift-cherrypick-robot @cardil @jeana-redhat