Skip to content

CNV-11201: RN Roll out of node network configuration policy#42355

Merged
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.10from
sjhala-ccs:cnv-11201-rn
Mar 10, 2022
Merged

CNV-11201: RN Roll out of node network configuration policy#42355
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.10from
sjhala-ccs:cnv-11201-rn

Conversation

@sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented Feb 24, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2022
@netlify
Copy link

netlify bot commented Feb 24, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 72938c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/62179dd714c0a5000866526a

😎 Browse the preview: https://deploy-preview-42355--osdocs.netlify.app/openshift-enterprise/latest/virt/virt-4-10-release-notes

@sjhala-ccs sjhala-ccs added branch/enterprise-4.10 CNV Label for all CNV PRs labels Feb 24, 2022
@sjhala-ccs sjhala-ccs added this to the Future Release milestone Feb 24, 2022
@sjhala-ccs
Copy link
Contributor Author

@rhrazdil Can you please review? Thank you.

Copy link

@rhrazdil rhrazdil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjhala-ccs The release note looks good.

But I also read the section that the release note refers to and one thing that's odd there is the Example Output at the end of this section: https://deploy-preview-42355--osdocs.netlify.app/openshift-enterprise/latest/virt/node_network/virt-updating-node-network-config.html#virt-creating-interface-on-nodes_virt-updating-node-network-config

There is:
2. Create the node network policy:

$ oc apply -f br1-eth1_policy.yaml

Example output

NAME                     STATUS
node01.br1-eth1-policy   Pending
node02.br1-eth1-policy   Progressing
node03.br1-eth1-policy   Available
node04.br1-eth1-policy   Progressing
node05.br1-eth1-policy   Progressing
node06.br1-eth1-policy   Pending

I'n not sure the user know at this moment, how to get to the example output? From the article, is appears as if the output would be produced by the oc apply command, but it is actually obtained by running oc get nnce, but IIUC, that is explained only in the following section.

@sjhala-ccs
Copy link
Contributor Author

@rhrazdil I would have to create a separate PR against the main branch to update the section that the release note refers to. For tracking purposes, can you please open a documentation BZ for this? Do you want me to move the Example output code block to the Confirming node network policy updates on nodes section or remove it completely from the documentation?

@rhrazdil
Copy link

rhrazdil commented Mar 1, 2022

Thanks @sjhala-ccs let's move forward with this and address that in a separate PR
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@rhrazdil
Copy link

rhrazdil commented Mar 1, 2022

@sjhala-ccs link to the issue: #42560

@ousleyp
Copy link
Member

ousleyp commented Mar 8, 2022

LGTM!

@ousleyp ousleyp added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 8, 2022
@bobfuru
Copy link
Contributor

bobfuru commented Mar 10, 2022

In preparation for OCP 4.10 GA, I'm moving the Milestone to "Next Release" as this PR did not make the merge by the 4.10 GA date. Post-GA, any open 4.10 PRs fall under the "Next Release" bucket in the same way that 4.6-4.9 PRs are already there. This change does not have any impact on the work in this PR; it's a housekeeping task to keep account of all PRs that had already merged by the 4.10 GA date. 😁

@bobfuru bobfuru modified the milestones: Future Release, Next Release Mar 10, 2022
@sjhala-ccs sjhala-ccs merged commit ba8f9e7 into openshift:enterprise-4.10 Mar 10, 2022
@sjhala-ccs sjhala-ccs deleted the cnv-11201-rn branch March 10, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 CNV Label for all CNV PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants