Skip to content

TELCODOCS-395: D/S Docs & RN: CNF-1153 DPDK deployment guide and best practices WIP#46316

Merged
pneedle-rh merged 1 commit intoopenshift:mainfrom
tmulquee:TELCODOCS-395
Jul 25, 2022
Merged

TELCODOCS-395: D/S Docs & RN: CNF-1153 DPDK deployment guide and best practices WIP#46316
pneedle-rh merged 1 commit intoopenshift:mainfrom
tmulquee:TELCODOCS-395

Conversation

@tmulquee
Copy link
Contributor

@tmulquee tmulquee commented Jun 3, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2022
@tmulquee tmulquee changed the title TELCODOCS-395: D/S Docs & RN: CNF-1153 DPDK deployment guide and best practices TELCODOCS-395: D/S Docs & RN: CNF-1153 DPDK deployment guide and best practices WIP Jun 3, 2022
@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 2 times, most recently from 1f09b3c to 2f61d58 Compare June 10, 2022 11:55
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2022
@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 3 times, most recently from 2fcd066 to 08633ac Compare June 10, 2022 13:01
@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 6 times, most recently from 3bcc8cc to e73797d Compare June 23, 2022 08:51
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 23, 2022
@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 10 times, most recently from 9a7b5e2 to 22eeecd Compare June 23, 2022 14:42
@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 3 times, most recently from d69ea25 to f6be0aa Compare July 5, 2022 13:00
@tmulquee tmulquee closed this Jul 21, 2022
@tmulquee tmulquee reopened this Jul 21, 2022
@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 2 times, most recently from d7a456d to 072e85b Compare July 22, 2022 07:56
pneedle-rh
pneedle-rh reviewed Jul 22, 2022
View reviewed changes
pneedle-rh
pneedle-rh reviewed Jul 22, 2022
View reviewed changes
modules/nw-sriov-dpdk-example-mellanox.adoc Outdated
Copy link
Contributor

@pneedle-rh pneedle-rh Jul 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file might still need relative indentation. What I meant by my earlier comment was that the top level indentation should start at the left of the page. Previously, some of the YAML examples had the top level indented to the right a few spaces. All of the lines should be indented according to the sections they are in, but the left-most level must have no spaces before it. But now, the file has no indentation at all. The lines should have been shifted to the left with their relative indentation remaining. Please let me know if you would like to discuss what I mean by this.

pneedle-rh
pneedle-rh reviewed Jul 22, 2022
View reviewed changes
modules/nw-sriov-dpdk-example-mellanox.adoc Outdated
Copy link
Contributor

@pneedle-rh pneedle-rh Jul 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This YAML example might need relative indentation, but the left-most level should have no spaces before it.

@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 4 times, most recently from d2aee75 to d9ce6af Compare July 22, 2022 10:17
@pneedle-rh
Copy link
Contributor

pneedle-rh commented Jul 22, 2022

@tmulquee thank you for making those changes.

Please squash your commits into one.

Please also ask for a final QE review of the code block examples, given all of the indentation updates that were made.

Other than this, the PR LGTM!

evgenLevin
evgenLevin reviewed Jul 24, 2022
View reviewed changes
@tmulquee tmulquee force-pushed the TELCODOCS-395 branch 5 times, most recently from 6eba003 to b43d6f5 Compare July 24, 2022 11:30
@evgenLevin
Copy link

evgenLevin commented Jul 24, 2022

LGTM

@pneedle-rh
Copy link
Contributor

pneedle-rh commented Jul 25, 2022

LGTM!

@pneedle-rh pneedle-rh merged commit e9ecaf5 into openshift:main Jul 25, 2022
@pneedle-rh
Copy link
Contributor

pneedle-rh commented Jul 25, 2022

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 25, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 25, 2022

@pneedle-rh: new pull request created: #48208

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SchSeba
SchSeba reviewed Jul 25, 2022
View reviewed changes
modules/nw-sriov-concept-dpdk-line-rate.adoc
@@ -0,0 +1,31 @@
// Module included in the following assemblies:
Copy link
Contributor

@SchSeba SchSeba Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tmulquee can you please review the old image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aireilly aireilly aireilly left review comments

@slovern slovern slovern left review comments

+3 more reviewers

@SchSeba SchSeba SchSeba left review comments

@pneedle-rh pneedle-rh pneedle-rh left review comments

@evgenLevin evgenLevin evgenLevin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.11 GA

Development

Successfully merging this pull request may close these issues.