Skip to content

BZ-2109524: Update troubleshooting steps for SNR resource removal#48151

Merged
mburke5678 merged 1 commit intoopenshift:mainfrom
abhatt-rh:bz-2109524
Jul 25, 2022
Merged

BZ-2109524: Update troubleshooting steps for SNR resource removal#48151
mburke5678 merged 1 commit intoopenshift:mainfrom
abhatt-rh:bz-2109524

Conversation

@abhatt-rh
Copy link
Contributor

@abhatt-rh abhatt-rh commented Jul 22, 2022

BZ-2109524: This PR updates information about removing Self Node Remediation resources after uninstalling the Operator

Version(s): OpenShift 4.11+

Issue:
https://bugzilla.redhat.com/show_bug.cgi?id=2109524

Preview:
http://file.rdu.redhat.com/avbhatt/bz-2109524/nodes/nodes/eco-self-node-remediation-operator.html#daemon-set-exists_self-node-remediation-operator-remediate-nodes

Additional information:
Prior to OpenShift 4.11, the Self Node Remediation Operator was known as the Poison Pill Operator. Relevant changes for Poison Pill Operator are applicable from versions 4.8-4.10 and they are addressed in a separate PR (#48157).

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2022
@abhatt-rh abhatt-rh force-pushed the bz-2109524 branch 2 times, most recently from c07e486 to 8ebdaa1 Compare July 22, 2022 10:10
@abhatt-rh
Copy link
Contributor Author

Hi @prabinovRedhat and @mshitrit
Request you to kindly review and approve changes for addressing bz-2109524. Thank you!

@prabinovRedhat
Copy link

prabinovRedhat commented Jul 24, 2022

/lgtm

@mshitrit
Copy link

lgtm

@abhatt-rh abhatt-rh changed the title [WIP]BZ-2109524: Update troubleshooting steps for SNR resource removal BZ-2109524: Update troubleshooting steps for SNR resource removal Jul 25, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file need a doc type at the start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. Thank you. I have added it now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete "manually." Since you're giving the commands, "manually" doesn't add anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Updated now

@nalhadef
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
Copy link
Contributor Author

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nalhadef Thank you for your feedback. I have incorporated the changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. Thank you. I have added it now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Updated now

@nalhadef
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@mburke5678 mburke5678 merged commit d4f9663 into openshift:main Jul 25, 2022
@mburke5678 mburke5678 added this to the Future Release milestone Jul 25, 2022
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@mburke5678: new pull request created: #48236

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 27, 2022
@kalexand-rh kalexand-rh removed this from the Future Release milestone Aug 9, 2022
@kalexand-rh kalexand-rh added this to the OCP 4.11 GA milestone Aug 9, 2022
@abhatt-rh abhatt-rh deleted the bz-2109524 branch October 12, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants