OSDOCS-3029: Added Azure Marketplace install content#48577
OSDOCS-3029: Added Azure Marketplace install content#48577mjpytlak merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
size/L
mjpytlak
force-pushed
the
osdocs-3029
branch
2 times, most recently
from
23a64f3 to
8f64fd3
Compare
|
@jeana-redhat Here is the Azure content. Wanted to give you a look at this ahead of our call next week. |
|
@patrickdillon @MayXuQQ Ready for SME and QE review. PTAL. |
MayXuQQ
left a comment
MayXuQQ
left a comment
There was a problem hiding this comment.
- suggest replace urn with version, then need not distinguish the command for EMEA
- sample missing azure
There was a problem hiding this comment.
when "urn": "redhat-limited:rh-ocp-worker:rh-ocp-worker-gen1:4.8.2021122100",
$az vm image show --urn redhat-limited:rh-ocp-worker:rh-ocp-worker-gen1:<version>
how about directly use $ az vm image show --urn <urn>
then need not specify the EMEA in the following,
just notes EMEA publisher is redhat-limited
There was a problem hiding this comment.
@MayXuQQ I would prefer to leave the current NA/EMEA examples as is. It is the clearest way to specify that the commands do differ. And I am using <version> to keep the doc technically accurate when 4.8.2021122100 is no longer the only available version to select.
There was a problem hiding this comment.
if you do no use urn,
need specify that the sku: 'rh-ocp-worker' and 'rh-ocp-worker-gen1', created VM generation is V2 or V1 ,
and more publisher redhat and redhat-limited (EMEA)
not just version different
$ az vm image list --all --offer rh-ocp-worker --publisher redhat -o table
Offer Publisher Sku Urn Version
------------- -------------- ------------------ -------------------------------------------------------------- --------------
rh-ocp-worker RedHat rh-ocp-worker RedHat:rh-ocp-worker:rh-ocp-worker:4.8.2021122100 4.8.2021122100
rh-ocp-worker RedHat rh-ocp-worker-gen1 RedHat:rh-ocp-worker:rh-ocp-worker-gen1:4.8.2021122100 4.8.2021122100
rh-ocp-worker redhat-limited rh-ocp-worker redhat-limited:rh-ocp-worker:rh-ocp-worker:4.8.2021122100 4.8.2021122100
rh-ocp-worker redhat-limited rh-ocp-worker-gen1 redhat-limited:rh-ocp-worker:rh-ocp-worker-gen1:4.8.2021122100 4.8.2021122100
There was a problem hiding this comment.
I updated the conceptual material at the beginning of this section with your suggestions. Also - thank you for the example output. I have added it to the procedure. PTAL. Thank you.
There was a problem hiding this comment.
compute:
- architecture: amd64
hyperthreading: Enabled
name: worker
platform:
azure:
type: Standard_D4s_v5
osImage:
publisher: redhat
offer: rh-ocp-worker
sku: rh-ocp-worker
version: 4.8.2021122100
replicas: 3
There was a problem hiding this comment.
Thank you. Good catch on the sample.
mjpytlak
force-pushed
the
osdocs-3029
branch
4 times, most recently
from
0674f3f to
88758ef
Compare
There was a problem hiding this comment.
Thank you. I removed the extra space. Not sure why this comment does not show the update, but the space has been removed and the published output looks good. [1]
Appreciate your feedback. Is there anything else or is the doc good to go?
mjpytlak
force-pushed
the
osdocs-3029
branch
2 times, most recently
from
cc8e2fe to
1f98062
Compare
|
/lgtm |
|
@patrickdillon when you have a moment PTAL. |
There was a problem hiding this comment.
Sorry to add a late change here, because I know this is due soon.
We should probably add a note/sentence somewhere to avoid potential confusion about versions (because the versioning here is confusing).
The output of this command shown in this table will have the correct version to be used. In this case it is 4.8.2021122100. What is potentially confusing to users is that the correct version here is going to be 4.8.x even though they could be installing 4.9, 4.10, or 4.11. We only distribute the 4.8 image, and it doesn't really matter because the VM image will be automatically updated to the latest image for their target version before the install completes.
So I think we probably need a note saying: even though you're installing 4.9(+) the correct image version to specify will be 4.8.x and your VMs will automatically be upgraded as part of the install.
There was a problem hiding this comment.
That is an excellent catch @patrickdillon. My latest commit adds a note to step 1. Please let me know what you think.
|
@MayXuQQ My latest commit adds a note to the first step of the procedure to clarify that regardless of the version you are installing, the correct version is 4.8.x |
|
/lgtm |
|
/lgtm Thanks mike! |
lpettyjo
left a comment
lpettyjo
left a comment
There was a problem hiding this comment.
I see 4 commits for this PR. Please squash to one.
mjpytlak
force-pushed
the
osdocs-3029
branch
from
e4cb0c5 to
dfc26d9
Compare
|
New changes are detected. LGTM label has been removed. |
Thanks @lpettyjo. Squashed. Anything else or good to go? |
|
🤖 Bots are busy building the preview. It will be available soon at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/333 |
There was a problem hiding this comment.
Looks like the second row, last column value isn't flush with the column heading.
mjpytlak
force-pushed
the
osdocs-3029
branch
from
dfc26d9 to
02a58b3
Compare
mjpytlak
added
the
peer-review-done
|
/cherrypick enterprise-4.12 |
|
/cherrypick enterprise-4.11 |
|
@mjpytlak: new pull request created: #50460 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mjpytlak: new pull request created: #50461 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Version(s):
CP to 4.11 and 4.12
Issue:
This PR addresses osdocs-3029.
Link to docs preview: