CNV-16785 and CNV-19602: Storage-related RNs for 4.11#48584
Merged
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.11from Aug 5, 2022
Merged
CNV-16785 and CNV-19602: Storage-related RNs for 4.11#48584sjhala-ccs merged 1 commit intoopenshift:enterprise-4.11from
sjhala-ccs merged 1 commit intoopenshift:enterprise-4.11from
Conversation
openshift-ci
bot
added
the
size/XS
bgaydosrh
changed the title
|
lgtm |
tiraboschi
approved these changes
Aug 5, 2022
sjhala-ccs
added
the
peer-review-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 4.11 only.
Jiras: https://issues.redhat.com/browse/CNV-16785 and https://issues.redhat.com/browse/CNV-19602
Direct doc preview link: http://file.rdu.redhat.com/bgaydos/CNV-16785/virt/virt-4-11-release-notes.html#virt-4-11-storage-new
These are both storage-related RNs and go in the same section of the RN file. Even though the feature topics live in the table of contents in virt or logging areas, I think they should be listed as storage-related due to their content (snapshots and boot sources).
Tagging @tiraboschi (CNV-16785) and @nunnatsa (CNV-19602) for code review.
--- Nahshon, I am creating another PR today to correct the feature doc for CNV-15737. As you have indicated, the disabling is for a predefined boot source, so I am simply calling this "boot source" to avoid confusion. I think we should go for boot source/custom boot source in the feature doc, for simplicity, and will ensure that's clear with the new PR.
Tagging @duyanyan for QE review on both notes.
Thanks
Bob