Skip to content

TELCODOCS-321: D/S Docs & RN: METAL-1 (MPINSTALL-72) Metal Day 1 Networking#48886

Closed
johnwilkins wants to merge 1 commit intoopenshift:mainfrom
johnwilkins:TELCODOCS-321-prep-node
Closed

TELCODOCS-321: D/S Docs & RN: METAL-1 (MPINSTALL-72) Metal Day 1 Networking#48886
johnwilkins wants to merge 1 commit intoopenshift:mainfrom
johnwilkins:TELCODOCS-321-prep-node

Conversation

@johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Aug 8, 2022

Contains a syntax fix for the BMH config file and additional minor edits.

Fixes: TELCODOCS-321

See https://issues.redhat.com/browse/TELCODOCS-321 for additional details.

Preview URL: http://jowilkin.com:8080/TELCODOCS-321-prep-node/installing/installing_bare_metal_ipi/ipi-install-expanding-the-cluster.html#preparing-the-bare-metal-node_ipi-install-expanding

For release(s): 4.12, 4.11 and 4.10
Signed-off-by: John Wilkins jowilkin@redhat.com

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2022
@awolffredhat
Copy link

The section starts with "Expanding the cluster requires a DHCP server. Each node must have a DHCP reservation."
This may need to be amended due to the new functionality.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not only an ip address, it's a full url. not sure what the technical term is.
example value of ://


redfish://192.168.123.1:8000/redfish/v1/Systems/ab9a6656-b9b7-4deb-9eb2-3a962087f7c9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must reference the first secret in the file, which in this example is called: openshift-worker--network-config-secret

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2022
@openshift-merge-robot
Copy link

@johnwilkins: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2022
@johnwilkins johnwilkins force-pushed the TELCODOCS-321-prep-node branch from 0fd28c7 to 9aaec9a Compare August 31, 2022 21:52
johnwilkins added a commit to johnwilkins/openshift-docs that referenced this pull request Sep 8, 2022
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Sep 12, 2022
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Sep 12, 2022
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Sep 12, 2022
snarayan-redhat pushed a commit to snarayan-redhat/openshift-docs that referenced this pull request Sep 20, 2022
kdrake20 pushed a commit to kdrake20/openshift-docs that referenced this pull request Oct 19, 2022
GroceryBoyJr pushed a commit to GroceryBoyJr/openshift-docs that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants