CFE-651: Release notes for AWS Load Balancer Operator#52292
Merged
snarayan-redhat merged 1 commit intoopenshift:enterprise-4.12from Nov 23, 2022
Merged
CFE-651: Release notes for AWS Load Balancer Operator#52292snarayan-redhat merged 1 commit intoopenshift:enterprise-4.12from
snarayan-redhat merged 1 commit intoopenshift:enterprise-4.12from
Conversation
openshift-ci
bot
added
the
size/XS
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4012 |
xenolinux
force-pushed
the
ingress-CFE-616
branch
from
566aa09 to
b890a9a
Compare
xenolinux
changed the title
thejasn
suggested changes
Oct 31, 2022
There was a problem hiding this comment.
This needs the under AWS Load Balancer Operator (new section)
There was a problem hiding this comment.
Suggested change
| In {product-title} 4.12, the Ingress Controller now implements the Kubernetes ingress specification for multiple matches. If multiple paths within an Ingress match a request then, the longest matching path gets the precedence. If two paths still match, paths with an exact path type over a prefix path type gets the precedence. | |
| In {product-title} 4.12, the AWS Load Balancer controller now implements the Kubernetes ingress specification for multiple matches. If multiple paths within an Ingress match a request then, the longest matching path gets the precedence. If two paths still match, paths with an exact path type over a prefix path type gets the precedence. |
xenolinux
force-pushed
the
ingress-CFE-616
branch
2 times, most recently
from
3e119f9 to
f7bbe46
Compare
xenolinux
changed the title
xenolinux
force-pushed
the
ingress-CFE-616
branch
from
f7bbe46 to
df74b82
Compare
Contributor
Author
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
Contributor
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
Contributor
bergerhoffer
left a comment
bergerhoffer
left a comment
There was a problem hiding this comment.
Just a few suggestions!
Contributor
There was a problem hiding this comment.
- Should "ingress" be capitalized in the first sentence?
- The phrase "gets the precedence" sounds odd to me. I think saying "takes precedence" is a more common phrase, so that's what I'd recommend (two places in this line).
Contributor
|
/label peer-review-done |
openshift-ci
bot
added
peer-review-done
xenolinux
force-pushed
the
ingress-CFE-616
branch
from
df74b82 to
a714772
Compare
Contributor
Author
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
Contributor
Author
|
/remove-label merge-review-needed |
openshift-ci
bot
removed
the
merge-review-needed
xenolinux
force-pushed
the
ingress-CFE-616
branch
2 times, most recently
from
8bf3781 to
2ecb1c8
Compare
xenolinux
changed the title
Contributor
Author
|
@lihongan Would you please review this PR? |
|
It looks good. Thank you @xenolinux |
alebedev87
reviewed
Nov 21, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| The AWS Load Balancer Operator sets the `EnableIPTargetType` flag to `false`. The AWS Load Balancer controller disables the support for services and ingress resources for `target-type` and `ip`. | |
| The AWS Load Balancer Operator sets the `EnableIPTargetType` feature gate to `false`. The AWS Load Balancer controller disables the support for services and ingress resources for `target-type` `ip`. |
xenolinux
force-pushed
the
ingress-CFE-616
branch
from
2ecb1c8 to
daceaff
Compare
Contributor
|
@xenolinux : Forgot to mention. The upstream version will be updated to 2.4.4 (openshift/aws-load-balancer-operator#79), this is worth mentioning in the release notes. |
xenolinux
force-pushed
the
ingress-CFE-616
branch
from
daceaff to
1a6f15f
Compare
alebedev87
reviewed
Nov 23, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| In {product-title} 4.12, the AWS Load Balancer controller now implements the Kubernetes Ingress specification for multiple matches. If multiple paths within an Ingress match a request, the longest matching path takes the precedence. If two paths still match, paths with an exact path type over a prefix path type takes the precedence. | |
| In {product-title} 4.12, the AWS Load Balancer controller now implements the Kubernetes Ingress specification for multiple matches. If multiple paths within an Ingress match a request, the longest matching path takes the precedence. If two paths still match, paths with an exact path type take precedence over a prefix path type. |
xenolinux
force-pushed
the
ingress-CFE-616
branch
from
1a6f15f to
07a562b
Compare
Contributor
|
/lgtm |
xenolinux
added
the
merge-review-needed
snarayan-redhat
added
the
merge-review-in-progress
snarayan-redhat
removed
merge-review-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version(s): 4.12
Issue: https://issues.redhat.com/browse/CFE-651
Link to docs preview: https://52292--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-12-release-notes.html#ocp-4-12-nw-aws-load-balancer-operator
QE review:
Additional information: