Agent 84: prepares the agent deployed cluster for mce#53967
Merged
jeana-redhat merged 1 commit intoopenshift:mainfrom Jan 12, 2023
Merged
Agent 84: prepares the agent deployed cluster for mce#53967jeana-redhat merged 1 commit intoopenshift:mainfrom
jeana-redhat merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/6878 |
Amrita42
force-pushed
the
Agent-84
branch
2 times, most recently
from
3c99721 to
ceafe0e
Compare
andfasano
reviewed
Dec 19, 2022
openshift-ci
bot
added
size/XL
Amrita42
force-pushed
the
Agent-84
branch
2 times, most recently
from
99c73e1 to
46b4a53
Compare
openshift-ci
bot
added
size/L
andfasano
reviewed
Jan 10, 2023
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
Amrita42
commented
Jan 10, 2023
modules/preparing-an-inital-cluster-deployment-for-mce-disconnected.adoc
Outdated
Show resolved
Hide resolved
Amrita42
force-pushed
the
Agent-84
branch
2 times, most recently
from
170ced7 to
00940e6
Compare
|
/lgtm |
Contributor
Author
|
@mhanss ptal and verify. |
Amrita42
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mhanss
reviewed
Jan 11, 2023
modules/preparing-an-inital-cluster-deployment-for-mce-disconnected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-disconnected.adoc
Outdated
Show resolved
Hide resolved
|
/lgtm |
bscott-rh
requested changes
Jan 11, 2023
Contributor
bscott-rh
left a comment
bscott-rh
left a comment
There was a problem hiding this comment.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-disconnected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-disconnected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-disconnected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
openshift-ci
bot
added
peer-review-done
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
kalexand-rh
removed
the
merge-review-needed
Contributor
|
@Amrita42, there's a bit more feedback that you need to implement before this can be merged. |
Contributor
Author
|
Yes sure @kalexand-rh , yes i missed that. Let me work on that now |
Contributor
Author
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
jeana-redhat
added
the
merge-review-in-progress
Contributor
jeana-redhat
left a comment
jeana-redhat
left a comment
There was a problem hiding this comment.
Noticed a few more formatting issues and small typos as I was checking structure for merge. I have also left a few terminology and style notes as I saw them. Sorry for the extra churn, but they are all pretty small things so hopefully not too much headache.
I also just got an answer about official naming for the multicluster engine, which needs to be applied throughout this PR:
- first instance: "multicluster engine for Kubernetes Operator"
- following instances: "multicluster engine"
- do not use: "MCE"
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
...nstalling_with_agent_based_installer/preparing-an-agent-based-installed-cluster-for-mce.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
modules/preparing-an-inital-cluster-deployment-for-mce-connected.adoc
Outdated
Show resolved
Hide resolved
jeana-redhat
removed
merge-review-in-progress
Contributor
Author
|
I am glad that the naming convention is sorted out just in time to implement in this PR . Thanks Jeana :) |
Contributor
Author
|
/label merge-review-needed @jeana-redhat ptal |
Contributor
|
Woooooooo @Amrita42 🎉 /cherrypick enterprise-4.12 |
|
@jeana-redhat: new pull request created: #54604 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andfasano @zaneb ptal .