OSDOCS-5006 & 5007:Automigration for Azure File and Vsphere by lpettyjo · Pull Request #55830 · openshift/openshift-docs

+[id="persistent-storage-csi-migration-sc-implications_{context}"]
+= Storage class implications
+
+For new {product-title} 4.11, and later, installations, the default storage class is the CSI storage class. All volumes provisioned using this storage class are CSI persistent volumes (PVs).


That's not true for all drivers, i am not sure if a generic statement works here. cc @gnufied

Yeah I don't think that statement works or is true. Either we have to create a table that explicitly lists in which release migration for that particular storage driver went GA or we shouldn't mention this at all.

Yes i was thinking about this. Maybe a table with the driver name, OCP version of the CSI driver GA as well as the CSI migration GA release / when it defaulted to CSI.

I was thinking that since this doc is specific to OCP 4.13, wouldn't the simplest solution be to state that for 4.13 and later, the default SC is the CSI one.

yes that would work too. There are some late changes on the vsphere side so I would hold on for the moment

modules/persistent-storage-csi-migration-sc.adoc

gcharot · 2023-03-23T18:00:07Z

@lpettyjo I think we should also remove the important red square from the vsphere CSI doc from the 4.13 docs (4.12 doc for your reference)
https://docs.openshift.com/container-platform/4.12/storage/container_storage_interface/persistent-storage-csi-vsphere.html#overview
cc @gnufied

duanwei33 · 2023-03-24T01:26:16Z

@ropatil010 Please help QE review.

lpettyjo · 2023-03-28T16:35:09Z

@lpettyjo I think we should also remove the important red square from the vsphere CSI doc from the 4.13 docs (4.12 doc for your reference) https://docs.openshift.com/container-platform/4.12/storage/container_storage_interface/persistent-storage-csi-vsphere.html#overview cc @gnufied

@gcharot This notice appears with all of the CSI drivers that were migrated. Should I remove it from all of them?

kcarmichael08 · 2023-05-01T20:04:12Z

/label peer-review-in-progress

kcarmichael08

Nice job distilling the info! I had some suggestions, mostly about making the content more modular when there are procedures and concepts mixed in the same module.

modules/persistent-storage-csi-migration-overview.adoc

modules/persistent-storage-csi-migration-sc.adoc

modules/persistent-storage-csi-migration-vsphere.adoc

modules/persistent-storage-csi-migration-overview.adoc

modules/persistent-storage-csi-migration-vsphere.adoc

duanwei33

Other looks good to be expect this minor comment.

modules/persistent-storage-csi-migration-vsphere.adoc

duanwei33 · 2023-05-08T12:57:53Z

Thanks for the update.
LGMT

modules/persistent-storage-csi-migration-sc.adoc

modules/persistent-storage-csi-migration-vsphere.adoc

modules/persistent-storage-csi-migration-overview.adoc

lpettyjo · 2023-05-09T15:38:55Z

#55830 (comment) Done.

openshift-ci · 2023-05-10T14:24:01Z

@ocpdocs-previewbot: user ocpdocs-previewbot is not trusted for pull request #55830

openshift-ci · 2023-05-10T14:41:11Z

@ocpdocs-previewbot: user ocpdocs-previewbot is not trusted for pull request #55830

sferich888 · 2023-05-10T15:03:44Z

/lgtm

gcharot · 2023-05-10T16:42:48Z

LGTM thanks!

kalexand-rh · 2023-05-10T18:57:23Z

@lpettyjo, it looks like the jobs for this one passed even though the PR says that it's still in progress: https://app.travis-ci.com/github/openshift/openshift-docs/builds/262941024

Please either double-check me and merge or bump the PR to rerun the job.

gnufied · 2023-05-10T19:49:29Z

lgtm

duanwei33 · 2023-05-11T01:39:27Z

LGMT from QE side

ropatil010 · 2023-05-11T04:17:00Z

lgtm

jsafrane · 2023-05-11T08:17:12Z

lgtm on behalf of @bertinatto

kalexand-rh · 2023-05-11T12:21:33Z

/cherrypick enterprise-4.13

openshift-cherrypick-robot · 2023-05-11T12:23:01Z

@kalexand-rh: new pull request created: #59906

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2023

lpettyjo added the branch/enterprise-4.13 label Feb 10, 2023

lpettyjo added this to the Planned for 4.13 GA milestone Feb 10, 2023

lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 10, 2023

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 10, 2023

lpettyjo force-pushed the OSDOCS-5006_And_5007 branch from 8bee0c8 to e0305ab Compare February 13, 2023 14:51

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 13, 2023

openshift-ci bot assigned tmalove Feb 13, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023

gcharot reviewed Mar 23, 2023

View reviewed changes

modules/persistent-storage-csi-migration-sc.adoc Outdated Show resolved Hide resolved

lpettyjo force-pushed the OSDOCS-5006_And_5007 branch from e0305ab to a3d4e0e Compare May 1, 2023 16:57

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 1, 2023

lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels May 1, 2023

openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 1, 2023

kcarmichael08 reviewed May 1, 2023

View reviewed changes

modules/persistent-storage-csi-migration-vsphere.adoc Outdated Show resolved Hide resolved

duanwei33 reviewed May 8, 2023

View reviewed changes

modules/persistent-storage-csi-migration-vsphere.adoc Outdated Show resolved Hide resolved

lpettyjo force-pushed the OSDOCS-5006_And_5007 branch from 864f67f to e14272b Compare May 8, 2023 12:26

sferich888 reviewed May 8, 2023

View reviewed changes

dfitzmau reviewed May 9, 2023

View reviewed changes

modules/persistent-storage-csi-migration-overview.adoc Show resolved Hide resolved

dfitzmau mentioned this pull request May 9, 2023

OSDOCS-5726: Added link to in install docs to vSphere automatic mig s… #59712

Merged

1 task

lpettyjo force-pushed the OSDOCS-5006_And_5007 branch from e14272b to 80936c9 Compare May 9, 2023 14:23

lpettyjo force-pushed the OSDOCS-5006_And_5007 branch 2 times, most recently from fae5f2f to fedb96f Compare May 10, 2023 13:59

OSDOCS-xxxx:Automigration for Azure File and Vsphere

6e53101

lpettyjo force-pushed the OSDOCS-5006_And_5007 branch from fedb96f to 6e53101 Compare May 10, 2023 14:10

openshift-ci bot assigned sferich888 May 10, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023

kalexand-rh closed this May 11, 2023

kalexand-rh reopened this May 11, 2023

kalexand-rh merged commit 66cc529 into openshift:main May 11, 2023

openshift-cherrypick-robot mentioned this pull request May 11, 2023

[enterprise-4.13] OSDOCS-5006 & 5007:Automigration for Azure File and Vsphere #59906

Merged

Conversation

lpettyjo commented Feb 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmalove commented Feb 10, 2023

Uh oh!

tmalove commented Feb 10, 2023

Uh oh!

ocpdocs-previewbot commented Feb 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmalove commented Feb 13, 2023

Uh oh!

gcharot Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

gnufied Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

gcharot Mar 24, 2023

Choose a reason for hiding this comment

Uh oh!

lpettyjo Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

gcharot Mar 28, 2023

Choose a reason for hiding this comment

Uh oh!

lpettyjo Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gcharot commented Mar 23, 2023

Uh oh!

duanwei33 commented Mar 24, 2023

Uh oh!

lpettyjo commented Mar 28, 2023

Uh oh!

kcarmichael08 commented May 1, 2023

Uh oh!

kcarmichael08 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duanwei33 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

duanwei33 commented May 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lpettyjo commented May 9, 2023

Uh oh!

openshift-ci bot commented May 10, 2023

Uh oh!

openshift-ci bot commented May 10, 2023

Uh oh!

sferich888 commented May 10, 2023

Uh oh!

gcharot commented May 10, 2023

Uh oh!

kalexand-rh commented May 10, 2023

Uh oh!

gnufied commented May 10, 2023

lpettyjo commented Feb 10, 2023 •

edited

Loading

ocpdocs-previewbot commented Feb 13, 2023 •

edited

Loading