Skip to content

[OSDOCS-5261] TP - External load balancers in place of default for ShiftStack IPI#57520

Merged
maxwelldb merged 22 commits intoopenshift:mainfrom
maxwelldb:ext-lbs-osdocs5261
May 4, 2023
Merged

[OSDOCS-5261] TP - External load balancers in place of default for ShiftStack IPI#57520
maxwelldb merged 22 commits intoopenshift:mainfrom
maxwelldb:ext-lbs-osdocs5261

Conversation

@maxwelldb maxwelldb added this to the Planned for 4.13 GA milestone Mar 21, 2023
@maxwelldb maxwelldb self-assigned this Mar 21, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2023

🤖 Updated build preview is available at:
https://57520--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/15291

@maxwelldb
Copy link
Contributor Author

@EmilienM Starting to put this together. Is this sort of thing essentially what you had in mind?

Additionally, do you think it's worth it to include and validate the Ansible content from your openshift/installer docs?

@maxwelldb maxwelldb requested a review from EmilienM March 21, 2023 22:03
Copy link
Member

@EmilienM EmilienM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good start.

@EmilienM
Copy link
Member

@EmilienM Starting to put this together. Is this sort of thing essentially what you had in mind?

Very good. I wonder if we are going to document it for all platforms where this feature works or just OSP?
It also works on BM, nutanix, ovirt (not sure it's supported), and vsphere.

Additionally, do you think it's worth it to include and validate the Ansible content from your openshift/installer docs?

No, my stuff is purely for PoC/dev/CI.

@maxwelldb
Copy link
Contributor Author

@EmilienM Updated with generic language for on-prem platforms.

modules/installation-load-balancing-user-infra.adoc is used in--I think--all of those platforms, so I can swap in that language in the rendered docs by changing contexts in that file.

@EmilienM
Copy link
Member

/lgtm

@maxwelldb maxwelldb requested a review from mandre April 21, 2023 20:14
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2023

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2023
@maxwelldb maxwelldb force-pushed the ext-lbs-osdocs5261 branch from 5352cf3 to 4234501 Compare April 28, 2023 19:48
@openshift-ci openshift-ci bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 28, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2023
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2023
@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.13

@openshift-cherrypick-robot

@maxwelldb: #57520 failed to apply on top of branch "enterprise-4.13":

Applying: Add install-config example
Applying: rename mod
Applying: Trying out placement
Applying: fixup! Add install-config example
Applying: Add TP snippet
Applying: Structure change and snippet addition to generic mod
Applying: Relocation and param addition
Applying: Attempt to bypass conditional + snippet failure
Applying: Apply gimme suggestions from code review
Applying: More changes from review
Applying: Make usermanaged lb content generic
Applying: ifeval tweak
Applying: Add to Kuryr IPI assembly
Applying: Update language in LB mod to handle u-m LBs
Applying: Add LI for feature in Understanding feature gates
.git/rebase-apply/patch:13: trailing whitespace.
// ** User-managed load balancers for clusters that run on {rh-openstack-first}. Enables user-managed load balancers at deployment. (`REPLACE_ME`) 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/nodes-cluster-enabling-features-about.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nodes-cluster-enabling-features-about.adoc
CONFLICT (content): Merge conflict in modules/nodes-cluster-enabling-features-about.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0015 Add LI for feature in Understanding feature gates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maxwelldb added a commit to maxwelldb/openshift-docs that referenced this pull request May 4, 2023
@maxwelldb maxwelldb deleted the ext-lbs-osdocs5261 branch May 4, 2023 14:44
maxwelldb added a commit that referenced this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants