Skip to content

OSDOCS-3606: Add IPv6 family first bare metal support#57903

Merged
jboxman-rh merged 1 commit intoopenshift:mainfrom
jboxman-rh:OSDOCS-3606
Apr 17, 2023
Merged

OSDOCS-3606: Add IPv6 family first bare metal support#57903
jboxman-rh merged 1 commit intoopenshift:mainfrom
jboxman-rh:OSDOCS-3606

Conversation

@jboxman-rh
Copy link

@jboxman-rh jboxman-rh commented Mar 29, 2023 •
edited
Loading

Adds support for IPv6 primary dual stack for bare metal, and IPv4/IPv6 dual stack for vSphere.

Version(s): 4.13

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@jboxman-rh jboxman-rh added this to the Planned for 4.13 GA milestone Mar 29, 2023
@jboxman-rh jboxman-rh self-assigned this Mar 29, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 29, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://57903--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14042

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2023 •
edited by openshift-ci bot
Loading

@jboxman-rh: This pull request references OSDOCS-3606 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue:

Link to docs preview:

Optional: Deploying with dual-stack networking
https://57903--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#modifying-install-config-for-dual-stack-network_ipi-install-installation-workflow

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2023 •
edited by openshift-ci bot
Loading

@jboxman-rh: This pull request references OSDOCS-3606 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2023 •
edited by openshift-ci bot
Loading

@jboxman-rh: This pull request references OSDOCS-3606 which is a valid jira issue.

Details

In response to this:

Adds support for IPv6 primary dual stack for bare metal, and IPv4/IPv6 dual stack for vSphere.

Version(s): 4.13

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh
Copy link
Author

jboxman-rh commented Mar 30, 2023

@cybertron, this updates the documentation for bare metal IPv6 and vSphere dual stack support at installation time.

@sgoveas
Copy link

sgoveas commented Apr 3, 2023

'IPI bare metal: Optional: Deploying with dual-stack networking' section looks good to me

@sgoveas
Copy link

sgoveas commented Apr 3, 2023

In the 'vSphere: Network configuration parameters' section, under the first Note, word report is repeated
Pods configured for host networking report only report their IPv6 addresses in pod.status.IP

Rest looks good to me

@jboxman-rh
Copy link
Author

jboxman-rh commented Apr 5, 2023

@sgoveas, thanks!

@sgoveas
Copy link

sgoveas commented Apr 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 13, 2023

New changes are detected. LGTM label has been removed.

@jboxman-rh jboxman-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 13, 2023
@GroceryBoyJr
Copy link
Contributor

GroceryBoyJr commented Apr 13, 2023

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 13, 2023
GroceryBoyJr
GroceryBoyJr reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

GroceryBoyJr commented Apr 13, 2023

@jboxman-rh I'm happy to report that my report is LGTM. 👍

@GroceryBoyJr
Copy link
Contributor

GroceryBoyJr commented Apr 13, 2023

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 13, 2023
@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 13, 2023
@sgoveas sgoveas mentioned this pull request Apr 17, 2023
Merged
1 task
@jboxman-rh
Copy link
Author

jboxman-rh commented Apr 17, 2023

@GroceryBoyJr, thanks!

@jboxman-rh jboxman-rh merged commit cdf36be into openshift:main Apr 17, 2023
@jboxman-rh
Copy link
Author

jboxman-rh commented Apr 17, 2023

/cherry-pick enterprise-4.13

@jboxman-rh jboxman-rh deleted the OSDOCS-3606 branch April 17, 2023 14:42
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 17, 2023

@jboxman-rh: new pull request created: #58811

Details

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sgoveas sgoveas

@jboxman-rh jboxman-rh

Labels

branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

4.13 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@jboxman-rh @ocpdocs-previewbot @openshift-ci-robot @sgoveas @GroceryBoyJr @openshift-cherrypick-robot @jab-rh