OSDOCS-5670: Remove multicluster references by opayne1 · Pull Request #58093 · openshift/openshift-docs

opayne1 · 2023-03-31T17:54:27Z

OSDOCS-5670: Remove multicluster references

Version(s):
4.13
Need to check if backporting all the way to 4.10 (I think we will need to).

Issue:
https://issues.redhat.com/browse/OSDOCS-5670>

Link to docs preview:
https://58093--docspreview.netlify.app/openshift-enterprise/latest/web_console/web-console.html
https://docs.openshift.com/container-platform/4.12/applications/working_with_helm_charts/understanding-helm.html#additional-resources

QE review:

QE has approved this change.

Additional information:
Release notes will be updated in follow-up PRs.

openshift-ci-robot · 2023-03-31T17:54:30Z

@opayne1: This pull request references OSDOCS-5670 which is a valid jira issue.

Details

In response to this:

OSDOCS-5670: Remove multicluster references

Version(s):
4.13
Need to check if backporting all the way to 4.10 (I think we will need to).

Issue:
https://issues.redhat.com/browse/OSDOCS-5670>

Link to docs preview:

QE review:

QE has approved this change.

Additional information:
Release notes will be updated in follow-up PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-31T17:54:43Z

@opayne1: This pull request references OSDOCS-5670 which is a valid jira issue.

Details

In response to this:

OSDOCS-5670: Remove multicluster references

Version(s):
4.13
Need to check if backporting all the way to 4.10 (I think we will need to).

Issue:
https://issues.redhat.com/browse/OSDOCS-5670>

Link to docs preview:

QE review:

QE has approved this change.

Additional information:
Release notes will be updated in follow-up PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ocpdocs-previewbot · 2023-03-31T18:12:40Z

🤖 Build preview is available at:
https://58093--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12938

openshift-ci-robot · 2023-03-31T18:14:34Z

@opayne1: This pull request references OSDOCS-5670 which is a valid jira issue.

Details

In response to this:

OSDOCS-5670: Remove multicluster references

Version(s):
4.13
Need to check if backporting all the way to 4.10 (I think we will need to).

Issue:
https://issues.redhat.com/browse/OSDOCS-5670>

Link to docs preview:
https://58093--docspreview.netlify.app/openshift-enterprise/latest/web_console/web-console.html
https://docs.openshift.com/container-platform/4.12/applications/working_with_helm_charts/understanding-helm.html#additional-resources

QE review:

QE has approved this change.

Additional information:
Release notes will be updated in follow-up PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

opayne1 · 2023-04-03T18:24:34Z

Hi @alimobrem @spadgett could you provide a review of this removal? I will need to do separate PRs for the release notes removal.

spadgett

lgtm

yapei · 2023-04-11T07:24:57Z

changes look good from QE side

bergerhoffer

LGTM, just one question!

bergerhoffer · 2023-04-11T14:04:56Z

web_console/web-console.adoc

 include::modules/web-console-overview.adoc[leveloffset=+1]
-include::modules/multi-cluster-about.adoc[leveloffset=+1]
-include::modules/enabling-multi-cluster-console.adoc[leveloffset=+2]
+// include::modules/multi-cluster-about.adoc[leveloffset=+1]


My only comment is whether these lines in both files can just be deleted instead of just commented out?

Also, should the module files actually be removed (or moved the unused_topics directory)? I'd recommend deleting the lines/removing the modules, unless they are expected to be needed again (then it's fine as is!).

Thanks, @bergerhoffer ! This feature is on hold for a few releases. Depending on what they decide to do with the feature, I expect to probably need this content again soon.

bergerhoffer · 2023-04-11T16:54:00Z

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

xltian · 2023-04-12T14:50:24Z

/lgtm

opayne1 · 2023-04-19T12:02:04Z

/cherrypick enterprise-4.10

opayne1 · 2023-04-19T12:02:13Z

/cherrypick enterprise-4.11

opayne1 · 2023-04-19T12:02:19Z

/cherrypick enterprise-4.12

opayne1 · 2023-04-19T12:02:26Z

/cherrypick enterprise-4.13

openshift-cherrypick-robot · 2023-04-19T12:03:32Z

@opayne1: #58093 failed to apply on top of branch "enterprise-4.10":

Applying: OSDOCS-5670: Remove multicluster references
Using index info to reconstruct a base tree...
M	applications/working_with_helm_charts/understanding-helm.adoc
Falling back to patching base and 3-way merge...
Auto-merging applications/working_with_helm_charts/understanding-helm.adoc
CONFLICT (content): Merge conflict in applications/working_with_helm_charts/understanding-helm.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-5670: Remove multicluster references
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-04-19T12:03:39Z

@opayne1: new pull request created: #58984

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-04-19T12:03:42Z

@opayne1: new pull request created: #58985

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-04-19T12:03:45Z

@opayne1: new pull request created: #58986

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OSDOCS-5670: Remove multicluster references

4a017fc

opayne1 added the branch/enterprise-4.13 label Mar 31, 2023

opayne1 added this to the Planned for 4.13 GA milestone Mar 31, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2023

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2023

This was referenced Apr 5, 2023

OSDOCS-5670: Removes references of Multicluster feature from 4.12 RNs #58281

Merged

OSDOCS-5670: Removes references of Multicluster feature from 4.11 RNs #58284

Merged

OSDOCS-5670: Removes references of Multicluster feature from 4.10 RNs #58285

Merged

spadgett approved these changes Apr 5, 2023

View reviewed changes

opayne1 added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 11, 2023

bergerhoffer added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 11, 2023

bergerhoffer reviewed Apr 11, 2023

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 11, 2023

openshift-ci bot assigned xltian Apr 12, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023

opayne1 added branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 labels Apr 19, 2023

opayne1 merged commit c4ccd30 into openshift:main Apr 19, 2023

openshift-cherrypick-robot mentioned this pull request Apr 19, 2023

[enterprise-4.11] OSDOCS-5670: Remove multicluster references #58984

Merged

openshift-cherrypick-robot mentioned this pull request Apr 19, 2023

[enterprise-4.12] OSDOCS-5670: Remove multicluster references #58985

Merged

openshift-cherrypick-robot mentioned this pull request Apr 19, 2023

[enterprise-4.13] OSDOCS-5670: Remove multicluster references #58986

Merged

opayne1 mentioned this pull request Apr 19, 2023

[enterprise-4.10]OSDOCS-5670: Remove multicluster references #58992

Merged

1 task

Conversation

opayne1 commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 31, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Mar 31, 2023

Uh oh!

openshift-ci-robot commented Mar 31, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

opayne1 commented Apr 3, 2023

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

yapei commented Apr 11, 2023

Uh oh!

bergerhoffer left a comment

Choose a reason for hiding this comment

Uh oh!

bergerhoffer Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

opayne1 Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

bergerhoffer commented Apr 11, 2023

Uh oh!

xltian commented Apr 12, 2023

Uh oh!

opayne1 commented Apr 19, 2023

Uh oh!

opayne1 commented Apr 19, 2023

Uh oh!

opayne1 commented Apr 19, 2023

Uh oh!

opayne1 commented Apr 19, 2023

Uh oh!

openshift-cherrypick-robot commented Apr 19, 2023

Uh oh!

openshift-cherrypick-robot commented Apr 19, 2023

Uh oh!

openshift-cherrypick-robot commented Apr 19, 2023

Uh oh!

openshift-cherrypick-robot commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

opayne1 commented Mar 31, 2023 •

edited

Loading

openshift-ci-robot commented Mar 31, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 31, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 31, 2023 •

edited by openshift-ci bot

Loading