Skip to content

[enterprise-4.13] OSDOCS-5676: add lsof rn entry#58171

Merged
jldohmann merged 1 commit intoopenshift:enterprise-4.13from
jldohmann:OSDOCS-5676
Apr 5, 2023
Merged

[enterprise-4.13] OSDOCS-5676: add lsof rn entry#58171
jldohmann merged 1 commit intoopenshift:enterprise-4.13from
jldohmann:OSDOCS-5676

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Apr 3, 2023

Version(s): 4.13

Issue: https://issues.redhat.com/browse/OSDOCS-5676

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-5676/release_notes/ocp-4-13-release-notes.html#ocp-4-13-lsof-rhcos

QE review:

  • QE has approved this change.

Additional information:

@jldohmann jldohmann added this to the Planned for 4.13 GA milestone Apr 3, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2023

@jldohmann: This pull request references OSDOCS-5676 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue: https://issues.redhat.com/browse/OSDOCS-5676

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-5676/release_notes/ocp-4-13-release-notes.html#ocp-4-13-lsof-rhcos

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 3, 2023

🤖 Updated build preview is available at:
https://58171--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/13397

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 3, 2023
@jldohmann jldohmann changed the title OSDOCS-5676: add lsof rn entry [enterprise-4.13] OSDOCS-5676: add lsof rn entry Apr 3, 2023
@kcarmichael08
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 4, 2023
@kcarmichael08
Copy link
Contributor

This looks good, but I think "lsof" shouldn't be capitalized in the heading, as it's a lower-case command. Is there a way to rewrite so that it doesn't come first? Jeana suggested "RCOS now includes lsof".

@kcarmichael08
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 4, 2023
@jldohmann
Copy link
Contributor Author

This looks good, but I think "lsof" shouldn't be capitalized in the heading, as it's a lower-case command. Is there a way to rewrite so that it doesn't come first? Jeana suggested "RCOS now includes lsof".

this is indeed better, thanks for the suggestion @kcarmichael08 (and Jeana heh), i'll implement that change

@jldohmann
Copy link
Contributor Author

jldohmann commented Apr 4, 2023

a7bbae3..fd6cdd7 implement peer review feedback
fd6cdd7..9ce8ada implement QE feedback

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 5, 2023

@jldohmann: This pull request references OSDOCS-5676 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13

Issue: https://issues.redhat.com/browse/OSDOCS-5676

Link to docs preview: http://file.rdu.redhat.com/jdohmann/OSDOCS-5676/release_notes/ocp-4-13-release-notes.html#ocp-4-13-lsof-rhcos

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann merged commit 3e4618b into openshift:enterprise-4.13 Apr 5, 2023
@jldohmann jldohmann deleted the OSDOCS-5676 branch April 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants