Skip to content

OSDOCS#5597: Added regionalized AWS STS URLs to the allow list for PrivateLink (DRAFT)#58175

Merged
stevsmit merged 1 commit intoopenshift:mainfrom
laubai:osdocs-5597-whitelist-sts-urls-prereq
May 2, 2023
Merged

OSDOCS#5597: Added regionalized AWS STS URLs to the allow list for PrivateLink (DRAFT)#58175
stevsmit merged 1 commit intoopenshift:mainfrom
laubai:osdocs-5597-whitelist-sts-urls-prereq

Conversation

@laubai
Copy link
Contributor

@laubai laubai commented Apr 4, 2023 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
@laubai laubai changed the title OSDOCS#5597: Added regionalized AWS STS URLs to the allow list for PrivateLink OSDOCS#5597: Added regionalized AWS STS URLs to the allow list for PrivateLink (DRAFT) Apr 4, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 4, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 4, 2023

🤖 Build preview is available at:
https://58175--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/13160

@vkareh
Copy link
Member

vkareh commented Apr 4, 2023

LGTM

/cc @jharrington22 can you confirm that the OIDC sts.amazonaws.com endpoint can/should be regionalized as well?

@arendej
Copy link
Contributor

arendej commented Apr 13, 2023

https://docs.aws.amazon.com/sdkref/latest/guide/feature-sts-regionalized-endpoints.html

@laubai laubai marked this pull request as ready for review April 19, 2023 04:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2023
@yuwang-RH
Copy link
Member

yuwang-RH commented Apr 24, 2023

LGTM~

@laubai
Copy link
Contributor Author

laubai commented Apr 26, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 26, 2023
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 26, 2023
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 branch/enterprise-4.13 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 26, 2023
@adellape adellape added this to the Continuous Release milestone Apr 26, 2023
@adellape
Copy link
Contributor

adellape commented Apr 26, 2023 •
edited
Loading

@laubai I wasn't sure if the merge-review request was meant to be a peer-review request, because I didn't see the peer review done on here yet (also noticed the "DRAFT" in PR title still), so I didn't want to assume merge-ability. But I've done peer review instead on it for now; please just re-queue for merge-review at this point. Thank you!

@laubai
Copy link
Contributor Author

laubai commented May 2, 2023

Thanks @adellape, I must have gotten my wires crossed. Re-queuing now!

@laubai
Copy link
Contributor Author

laubai commented May 2, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 2, 2023
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR lgtm Indicates that a PR is ready to be merged. and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels May 2, 2023
@stevsmit
Copy link
Member

stevsmit commented May 2, 2023

LGTM!

@stevsmit stevsmit merged commit 40d8293 into openshift:main May 2, 2023
@stevsmit
Copy link
Member

stevsmit commented May 2, 2023

/cherry-pick enterprise-4.12

@stevsmit
Copy link
Member

stevsmit commented May 2, 2023

/cherry-pick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 2, 2023

@stevsmit: new pull request created: #59470

Details

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 2, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 2, 2023

@stevsmit: new pull request created: #59471

Details

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adellape adellape adellape approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@laubai @ocpdocs-previewbot @vkareh @arendej @yuwang-RH @adellape @stevsmit @openshift-cherrypick-robot