Skip to content

CNV-21228: new content#58385

Merged
apinnick merged 1 commit intoopenshift:mainfrom
sabrinajess:CNV21228
Apr 16, 2023
Merged

CNV-21228: new content#58385
apinnick merged 1 commit intoopenshift:mainfrom
sabrinajess:CNV21228

Conversation

@sabrinajess
Copy link
Contributor

@sabrinajess sabrinajess commented Apr 6, 2023 •
edited
Loading

Version(s): 4.13+

Issue: CNV-21228

Link to docs preview: https://58385--docspreview.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-create-vms.html#virt-creating-vm-instancetype_virt-create-vms

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-21228 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: CNV-21228

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-21228 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: CNV-21228

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-21228 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: CNV-21228

Link to docs preview: http://file.rdu.redhat.com/sjess/CNV21228/virt/virtual_machines/virt-create-vms.html#virt-creating-vm-instancetype_virt-create-vms

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sabrinajess sabrinajess force-pushed the CNV21228 branch 2 times, most recently from 15a2ad5 to 775a65e Compare April 6, 2023 20:22
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 6, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://58385--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/13967

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2023 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-21228 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: CNV-21228

Link to docs preview: https://58385--docspreview.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-create-vms.html#virt-creating-vm-instancetype_virt-create-vms

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sabrinajess
Copy link
Contributor Author

sabrinajess commented Apr 7, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 7, 2023
@ousleyp ousleyp added peer-review-in-progress Signifies that the peer review team is reviewing this PR CNV Label for all CNV PRs branch/enterprise-4.13 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 7, 2023
@ousleyp ousleyp added this to the Planned for 4.13 GA milestone Apr 7, 2023
@sabrinajess sabrinajess force-pushed the CNV21228 branch 2 times, most recently from 53f2dbb to 6d5e812 Compare April 11, 2023 15:45
@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 11, 2023
@ousleyp
Copy link
Member

ousleyp commented Apr 13, 2023

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 13, 2023
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 13, 2023
@snarayan-redhat snarayan-redhat added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 13, 2023
@RoniKishner
Copy link

RoniKishner commented Apr 13, 2023

QA approved

@sabrinajess
Copy link
Contributor Author

sabrinajess commented Apr 13, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 13, 2023 •
edited by openshift-ci bot
Loading

@sabrinajess: This pull request references CNV-21228 which is a valid jira issue.

Details

In response to this:

Version(s): 4.13+

Issue: CNV-21228

Link to docs preview: https://58385--docspreview.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virt-create-vms.html#virt-creating-vm-instancetype_virt-create-vms

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhatt-rh
Copy link
Contributor

abhatt-rh commented Apr 14, 2023

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 14, 2023
@apinnick apinnick merged commit 7bd0e28 into openshift:main Apr 16, 2023
@apinnick
Copy link
Contributor

apinnick commented Apr 16, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 16, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 16, 2023

@apinnick: new pull request created: #58772

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick
Copy link
Contributor

apinnick commented Apr 16, 2023

@abhatt-rh
@kalexand-rh gave me the go-ahead to merge this PR.

@abhatt-rh
Copy link
Contributor

abhatt-rh commented Apr 16, 2023

@abhatt-rh
@kalexand-rh gave me the go-ahead to merge this PR.

@apinnick Thank you for letting me know.

@abhatt-rh abhatt-rh removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 17, 2023
@apinnick apinnick mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

branch/enterprise-4.13 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

4.13 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@sabrinajess @openshift-ci-robot @ocpdocs-previewbot @ousleyp @RoniKishner @abhatt-rh @apinnick @openshift-cherrypick-robot @snarayan-redhat