OCPBUGS#11575: Document Operator SDK installation for macOS by xenolinux · Pull Request #58866 · openshift/openshift-docs

xenolinux · 2023-04-18T07:56:29Z

Version(s): 4.12+

Issue: https://issues.redhat.com/browse/OCPBUGS-11575

Link to docs preview: https://58866--docspreview.netlify.app/openshift-enterprise/latest/cli_reference/osdk/cli-osdk-install.html

https://58866--docspreview.netlify.app/openshift-enterprise/latest/cli_reference/osdk/cli-osdk-install.html

https://58866--docspreview.netlify.app/openshift-enterprise/latest/operators/operator_sdk/osdk-installing-cli.html

QE review:

QE has approved this change.

Additional information:

ocpdocs-previewbot · 2023-04-18T08:03:39Z

🤖 Updated build preview is available at:
https://58866--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14576

KeenonLee

/lgtm

xenolinux · 2023-04-18T09:49:02Z

@KeenonLee Is this change valid for 4.9+ ocp versions?

KeenonLee · 2023-04-18T09:57:14Z

We can support darwin/arm64 client from 4.12.

xenolinux · 2023-04-18T10:16:47Z

/label peer-review-needed

nalhadef · 2023-04-18T11:32:51Z

/label peer-review-in-progress
/remove-label peer-review-needed

nalhadef · 2023-04-18T11:43:27Z

/remove-label peer-review-in-progress
/label peer-review-done

xenolinux · 2023-04-19T08:58:45Z

/label merge-review-needed

openshift-ci · 2023-04-19T09:04:59Z

New changes are detected. LGTM label has been removed.

jldohmann

LGTM, though I did leave a question below...feel free to ping me again for merge, thank you!

jldohmann · 2023-04-19T15:07:11Z

cli_reference/osdk/cli-osdk-install.adoc

 The Operator SDK provides a command-line interface (CLI) tool that Operator developers can use to build, test, and deploy an Operator. You can install the Operator SDK CLI on your workstation so that you are prepared to start authoring your own Operators.

-Operator authors with cluster administrator access to a Kubernetes-based cluster, such as {product-title}, can use the Operator SDK CLI to develop their own Operators based on Go, Ansible, or Helm. link:https://kubebuilder.io/[Kubebuilder] is embedded into the Operator SDK as the scaffolding solution for Go-based Operators, which means existing Kubebuilder projects can be used as is with the Operator SDK and continue to work.
+Operator authors with cluster administrator access to a Kubernetes-based cluster, such as {product-title}, can use the Operator SDK CLI to develop their own Operators based on Go, Ansible, Java, or Helm. link:https://kubebuilder.io/[Kubebuilder] is embedded into the Operator SDK as the scaffolding solution for Go-based Operators, which means existing Kubebuilder projects can be used as is with the Operator SDK and continue to work.


I don't see this addition of Java reflected in the preview:

am I missing something?

https://58866--docspreview.netlify.app/openshift-enterprise/latest/cli_reference/osdk/cli-osdk-install.html ==> It's now showing here. Sorry, actually I had pasted the wrong location as a preview.

Updated comment 0 with the related preview links.

xenolinux · 2023-04-20T06:21:30Z

/label merge-review-needed

mburke5678 · 2023-04-20T12:43:03Z

modules/osdk-installing-cli-macos.adoc

+
+.Procedure
+
+. For `amd64` and `arm64` architectures, navigate to the link:https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/operator-sdk/[OpenShift mirror site for `amd64` architecture] and link:https://mirror.openshift.com/pub/openshift-v4/arm64/clients/operator-sdk/[OpenShift mirror site for `arm64` architecture] respectively.


s/amd64 and arm64/the amd64 and arm64
s/amd64 architecture/the amd64 architecture
s/ arm64 architecture/the arm64 architecture

mburke5678 · 2023-04-20T12:43:47Z

@xenolinux Can you address my one pesky nit? Otherwise looks good to merge.

mburke5678 · 2023-04-20T14:49:44Z

/cherrypick enterprise-4.12

mburke5678 · 2023-04-20T14:49:52Z

/cherrypick enterprise-4.13

openshift-cherrypick-robot · 2023-04-20T14:50:29Z

@mburke5678: new pull request created: #59080

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2023-04-20T14:50:36Z

@mburke5678: new pull request created: #59081

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2023

xenolinux force-pushed the mac-operatorsdk branch from 5f9ddf4 to fc2db64 Compare April 18, 2023 07:59

KeenonLee reviewed Apr 18, 2023

View reviewed changes

openshift-ci bot assigned KeenonLee Apr 18, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 18, 2023

openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 18, 2023

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 18, 2023

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 19, 2023

xenolinux force-pushed the mac-operatorsdk branch from fc2db64 to a867c66 Compare April 19, 2023 09:04

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023

xenolinux force-pushed the mac-operatorsdk branch from a867c66 to b46214e Compare April 19, 2023 09:06

jldohmann added branch/enterprise-4.12 branch/enterprise-4.13 merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Apr 19, 2023

jldohmann added this to the Continuous Release milestone Apr 19, 2023

jldohmann reviewed Apr 19, 2023

View reviewed changes

jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 19, 2023

xenolinux force-pushed the mac-operatorsdk branch from b46214e to 134a26f Compare April 20, 2023 06:09

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 20, 2023

mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 20, 2023

mburke5678 reviewed Apr 20, 2023

View reviewed changes

OCPBUGS#11575: Document Operator SDK installation for macOS

3236da1

xenolinux force-pushed the mac-operatorsdk branch from 134a26f to 3236da1 Compare April 20, 2023 12:49

mburke5678 merged commit 5b3f66c into openshift:main Apr 20, 2023

openshift-cherrypick-robot mentioned this pull request Apr 20, 2023

[enterprise-4.12] OCPBUGS#11575: Document Operator SDK installation for macOS #59080

Merged

openshift-cherrypick-robot mentioned this pull request Apr 20, 2023

[enterprise-4.13] OCPBUGS#11575: Document Operator SDK installation for macOS #59081

Merged

mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 20, 2023


		.Procedure

		. For `amd64` and `arm64` architectures, navigate to the link:https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/operator-sdk/[OpenShift mirror site for `amd64` architecture] and link:https://mirror.openshift.com/pub/openshift-v4/arm64/clients/operator-sdk/[OpenShift mirror site for `arm64` architecture] respectively.

Conversation

xenolinux commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KeenonLee left a comment

Choose a reason for hiding this comment

Uh oh!

xenolinux commented Apr 18, 2023

Uh oh!

KeenonLee commented Apr 18, 2023

Uh oh!

xenolinux commented Apr 18, 2023

Uh oh!

nalhadef commented Apr 18, 2023

Uh oh!

nalhadef commented Apr 18, 2023

Uh oh!

xenolinux commented Apr 19, 2023

Uh oh!

openshift-ci bot commented Apr 19, 2023

Uh oh!

jldohmann left a comment

Choose a reason for hiding this comment

Uh oh!

jldohmann Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

xenolinux Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xenolinux Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xenolinux commented Apr 20, 2023

Uh oh!

mburke5678 Apr 20, 2023

Choose a reason for hiding this comment

Uh oh!

mburke5678 commented Apr 20, 2023

Uh oh!

mburke5678 commented Apr 20, 2023

Uh oh!

mburke5678 commented Apr 20, 2023

Uh oh!

openshift-cherrypick-robot commented Apr 20, 2023

Uh oh!

openshift-cherrypick-robot commented Apr 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xenolinux commented Apr 18, 2023 •

edited

Loading

ocpdocs-previewbot commented Apr 18, 2023 •

edited

Loading

xenolinux Apr 20, 2023 •

edited

Loading

xenolinux Apr 20, 2023 •

edited

Loading