Skip to content

OSDOCS-6429: Support Windows Containers on Nutanix#65598

Merged
bscott-rh merged 1 commit intoopenshift:mainfrom
DCChadwick:osdocs6429
Dec 4, 2023
Merged

OSDOCS-6429: Support Windows Containers on Nutanix#65598
bscott-rh merged 1 commit intoopenshift:mainfrom
DCChadwick:osdocs6429

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented Oct 2, 2023 •
edited by bscott-rh
Loading

Version(s): 4.14+

Issue: OSDOCS-6429

Link to docs preview: https://65598--docspreview.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-nutanix

QE review:

  • QE has approved this change.

Additional information: This PR replaces PR #61572

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-6429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14

Issue: OSDOCS-6429

Link to docs preview: link coming soon

QE review:

  • QE has approved this change.

Additional information: This PR replaces PR #61572

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-6429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14

Issue: OSDOCS-6429

Link to docs preview: link coming soon

QE review:

  • QE has approved this change.

Additional information: This PR replaces PR #61572

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-6429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14

Issue: OSDOCS-6429

Link to docs preview: link coming soon

QE review:

  • QE has approved this change.

Additional information: This PR replaces PR #61572

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 2, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://65598--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/35688

@mwerner2113
Copy link
Contributor

mwerner2113 commented Oct 9, 2023

@arnaik-rh this is ready for QE review.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2023 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-6429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14

Issue: OSDOCS-6429

Link to docs preview: https://65598--docspreview.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-nutanix

QE review:

  • QE has approved this change.

Additional information: This PR replaces PR #61572

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

@DCChadwick: The label(s) /label on_qa cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label on_qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jfrancoa
jfrancoa reviewed Oct 19, 2023
View reviewed changes
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Oct 30, 2023

I've opened the enterprise-4.15 branch. Please review your PR and update the applicable versions to also cover 4.15 if you expect that the changes in this PR will be valid in that branch.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2023
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-6429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14

Issue: OSDOCS-6429

Link to docs preview: https://65598--docspreview.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-nutanix

QE review:

  • QE has approved this change.

Additional information: This PR replaces PR #61572

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DCChadwick
Copy link
Author

DCChadwick commented Nov 28, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 28, 2023
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Nov 28, 2023

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 28, 2023
@bergerhoffer bergerhoffer added this to the Continuous Release milestone Nov 28, 2023
bergerhoffer
bergerhoffer reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending back since I think the assembly isn't properly including modules like it was probably meant to.

Feel free to ping me directly or just put it back into the queue once you've updated!

@bergerhoffer bergerhoffer removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 28, 2023
bergerhoffer
bergerhoffer reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things!

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Nov 29, 2023

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 29, 2023
@DCChadwick DCChadwick force-pushed the osdocs6429 branch 2 times, most recently from e8fbb4d to 8db4950 Compare November 29, 2023 18:55
@DCChadwick
Copy link
Author

DCChadwick commented Nov 29, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 29, 2023
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 29, 2023
jldohmann
jldohmann reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the preview is affected by some of the callouts: they extend into the table of contents section of the page. I'm not sure if it's a netlify quirk or if it'll reflect what we'll see when the changes go live. @DCChadwick does your local build reflect what is seen here?
Screenshot 2023-11-29 at 2 08 47 PM

Other than that, the changes look good to me

@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 29, 2023
jeana-redhat
jeana-redhat reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be verified by SMEs, but I have pulled in the compute content any place the control plane content was used.

@DCChadwick
Copy link
Author

DCChadwick commented Dec 4, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 4, 2023
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2023 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-6429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Version(s): 4.14+

Issue: OSDOCS-6429

Link to docs preview: https://65598--docspreview.netlify.app/openshift-enterprise/latest/windows_containers/creating_windows_machinesets/creating-windows-machineset-nutanix

QE review:

  • QE has approved this change.

Additional information: This PR replaces PR #61572

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh bscott-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 4, 2023
@bscott-rh
Copy link
Contributor

bscott-rh commented Dec 4, 2023

Merge review LGTM.

@bscott-rh bscott-rh merged commit 039238c into openshift:main Dec 4, 2023
@bscott-rh
Copy link
Contributor

bscott-rh commented Dec 4, 2023

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 4, 2023

@bscott-rh: new pull request created: #68877

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2023
Merged
@bscott-rh
Copy link
Contributor

bscott-rh commented Dec 4, 2023

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 4, 2023

@bscott-rh: new pull request created: #68878

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@jldohmann jldohmann jldohmann left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

+1 more reviewer

@jfrancoa jfrancoa jfrancoa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.