Skip to content

OSDOCS-8252: adds OVN-K i/c to RNs#66502

Merged
JoeAldinger merged 1 commit intoopenshift:enterprise-4.14from
JoeAldinger:OSDOCS-8252
Oct 23, 2023
Merged

OSDOCS-8252: adds OVN-K i/c to RNs#66502
JoeAldinger merged 1 commit intoopenshift:enterprise-4.14from
JoeAldinger:OSDOCS-8252

Conversation

@JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Oct 18, 2023 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2023 •
edited by openshift-ci bot
Loading

@JoeAldinger: This pull request references OSDOCS-8252 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 18, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://66502--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/29564

@JoeAldinger JoeAldinger added this to the Planned for 4.14 GA milestone Oct 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2023 •
edited by openshift-ci bot
Loading

@JoeAldinger: This pull request references OSDOCS-8252 which is a valid jira issue.

Details

In response to this:

Version(s):
4.14

Issue:
https://issues.redhat.com/browse/OSDOCS-8252

Link to docs preview:
https://66502--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-notable-technical-changes:~:text=OVN%2DKuberenetes%20interconnect

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2023
@JoeAldinger JoeAldinger added peer-review-needed Signifies that the peer review team needs to review this PR and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2023
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 18, 2023
mburke5678
mburke5678 reviewed Oct 18, 2023
View reviewed changes
mburke5678
mburke5678 reviewed Oct 18, 2023
View reviewed changes
mburke5678
mburke5678 reviewed Oct 18, 2023
View reviewed changes
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 18, 2023
@mburke5678
Copy link
Contributor

mburke5678 commented Oct 18, 2023

@JoeAldinger A few nits. Otherwise LGTM

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
tssurya
tssurya suggested changes Oct 19, 2023
View reviewed changes
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2023
@JoeAldinger JoeAldinger added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels Oct 20, 2023
@JoeAldinger
Copy link
Contributor Author

JoeAldinger commented Oct 20, 2023

Put this back in the queue because it was changed significantly.

@kalexand-rh kalexand-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 20, 2023
kalexand-rh
kalexand-rh reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the heading capitalization and consider the suggested edits to the body text.

release_notes/ocp-4-14-release-notes.adoc Outdated

[discrete]
[id="ocp-4-14-ovn-k-interconnect"]
=== Improved Scaling and Stability with Open Virtual Network (OVN) Optimizations
Copy link
Contributor

@kalexand-rh kalexand-rh Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Improved Scaling and Stability with Open Virtual Network (OVN) Optimizations
=== Improved scaling and stability with Open Virtual Network (OVN) optimizations

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 20, 2023
@mcurry-rh
Copy link

mcurry-rh commented Oct 23, 2023

I believe that "node" should be pluralized (?) in the sentence: "Network flow data is now localized to cluster node...", but otherwise, LGTM! @kalexand-rh @JoeAldinger

@JoeAldinger JoeAldinger merged commit 735d49b into openshift:enterprise-4.14 Oct 23, 2023
@JoeAldinger JoeAldinger deleted the OSDOCS-8252 branch October 23, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@kalexand-rh kalexand-rh kalexand-rh left review comments

+1 more reviewer

@tssurya tssurya tssurya requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.14 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@JoeAldinger @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @mcurry-rh @tssurya @kalexand-rh @openshift-merge-robot