TELCODOCS-1347: Adding link to SiteConfig CR ref by amolnar-gh · Pull Request #66876 · openshift/openshift-docs

amolnar-gh · 2023-10-25T13:17:00Z

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1347

Link to docs preview: https://66876--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-ztp-support-custom-node-labels

QE review:

QE has approved this change.

Additional information: The nodeLabel content was accidentally removed in PR #60679 while restructuring. Adding a link to the new section.
All acks can be found in PR #63576

openshift-ci-robot · 2023-10-25T13:17:05Z

@amolnar-rh: This pull request references TELCODOCS-1347 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/TELCODOCS-1347

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ocpdocs-previewbot · 2023-10-25T13:21:06Z

🤖 Updated build preview is available at:
https://66876--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/30099

openshift-ci-robot · 2023-10-25T13:21:10Z

@amolnar-rh: An error was encountered searching for bug TELCODOCS-1347 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1347

Link to docs preview:

QE review:

QE has approved this change.

Additional information: The nodeLabel content was accidentally removed in PR #60679 while restructuring. Adding a link to the new section.
All acks can be found in PR #63576

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-25T13:21:34Z

@amolnar-rh: This pull request references TELCODOCS-1347 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1347

Link to docs preview:

QE review:

QE has approved this change.

Additional information: The nodeLabel content was accidentally removed in PR #60679 while restructuring. Adding a link to the new section.
All acks can be found in PR #63576

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

amolnar-gh · 2023-10-25T13:22:30Z

/label peer-review-needed

xenolinux · 2023-10-25T13:37:18Z

/label peer-review-in-progress

aireilly

lgtm

openshift-ci-robot · 2023-10-25T13:52:33Z

@amolnar-rh: This pull request references TELCODOCS-1347 which is a valid jira issue.

Details

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/TELCODOCS-1347

Link to docs preview: https://66876--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-ztp-support-custom-node-labels

QE review:

QE has approved this change.

Additional information: The nodeLabel content was accidentally removed in PR #60679 while restructuring. Adding a link to the new section.
All acks can be found in PR #63576

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xenolinux

One suggestion otherwise LGTM.

I am new on the peer review squad. Please wait until @abhatt-rh gives my review the go-ahead before implementing any feedback. Thanks!

xenolinux · 2023-10-25T13:51:18Z

release_notes/ocp-4-14-release-notes.adoc

 ==== Support for adding custom node labels in the SiteConfig CR through {ztp}

-With this update, you can add the `nodeLabels` field in the `SiteConfig` CR to create custom roles for nodes in managed clusters. For more information about how to add custom labels, see xref:../scalability_and_performance/ztp_far_edge/ztp-deploying-far-edge-sites.adoc#ztp-deploying-a-site_ztp-deploying-far-edge-sites[Deploying a managed cluster with SiteConfig and {ztp}] or xref:../scalability_and_performance/ztp_far_edge/ztp-manual-install.adoc#ztp-generating-install-and-config-crs-manually_ztp-manual-install[Generating {ztp} installation and configuration CRs manually].
+With this update, you can add the `nodeLabels` field in the `SiteConfig` CR to create custom roles for nodes in managed clusters. For more information about how to add custom labels, see xref:../scalability_and_performance/ztp_far_edge/ztp-deploying-far-edge-sites.adoc#ztp-deploying-a-site_ztp-deploying-far-edge-sites[Deploying a managed cluster with SiteConfig and {ztp}], xref:../scalability_and_performance/ztp_far_edge/ztp-manual-install.adoc#ztp-generating-install-and-config-crs-manually_ztp-manual-install[Generating {ztp} installation and configuration CRs manually], and xref:../scalability_and_performance/ztp_far_edge/ztp-deploying-far-edge-sites.html#ztp-sno-siteconfig-config-reference_ztp-deploying-far-edge-sites[{sno} SiteConfig CR installation reference]


Suggested change

With this update, you can add the `nodeLabels` field in the `SiteConfig` CR to create custom roles for nodes in managed clusters. For more information about how to add custom labels, see xref:../scalability_and_performance/ztp_far_edge/ztp-deploying-far-edge-sites.adoc#ztp-deploying-a-site_ztp-deploying-far-edge-sites[Deploying a managed cluster with SiteConfig and {ztp}], xref:../scalability_and_performance/ztp_far_edge/ztp-manual-install.adoc#ztp-generating-install-and-config-crs-manually_ztp-manual-install[Generating {ztp} installation and configuration CRs manually], and xref:../scalability_and_performance/ztp_far_edge/ztp-deploying-far-edge-sites.html#ztp-sno-siteconfig-config-reference_ztp-deploying-far-edge-sites[{sno} SiteConfig CR installation reference]

With this update, you can add the `nodeLabels` field in the `SiteConfig` CR to create custom roles for nodes in managed clusters. For more information about how to add custom labels, see xref:../scalability_and_performance/ztp_far_edge/ztp-deploying-far-edge-sites.adoc#ztp-deploying-a-site_ztp-deploying-far-edge-sites[Deploying a managed cluster with SiteConfig and {ztp}], xref:../scalability_and_performance/ztp_far_edge/ztp-manual-install.adoc#ztp-generating-install-and-config-crs-manually_ztp-manual-install[Generating {ztp} installation and configuration CRs manually], and xref:../scalability_and_performance/ztp_far_edge/ztp-deploying-far-edge-sites.adoc#ztp-sno-siteconfig-config-reference_ztp-deploying-far-edge-sites[{sno} SiteConfig CR installation reference].

Can you please provide the preview link?

Here it is: https://66876--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-ztp-support-custom-node-labels
And I added it to the description too

xenolinux · 2023-10-25T13:54:47Z

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

abhatt-rh

@amolnar-rh and @xenolinux: Peer review LGTM!

amolnar-gh · 2023-10-25T14:51:41Z

/label merge-review-needed

abhatt-rh · 2023-10-25T14:53:04Z

/label merge-review-in-progress

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2023

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2023

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2023

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 25, 2023

aireilly approved these changes Oct 25, 2023

View reviewed changes

openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 25, 2023

xenolinux reviewed Oct 25, 2023

View reviewed changes

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 25, 2023

TELCODOCS-1347: Adding link to SiteConfig CR ref

98a184e

amolnar-gh force-pushed the TELCODOCS-1347-RN-fix branch from 184d5aa to 98a184e Compare October 25, 2023 14:09

abhatt-rh reviewed Oct 25, 2023

View reviewed changes

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 25, 2023

abhatt-rh added this to the Planned for 4.14 GA milestone Oct 25, 2023

abhatt-rh added branch/enterprise-4.14 telco Label for all Telco PRs labels Oct 25, 2023

openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 25, 2023

abhatt-rh merged commit b9a4e78 into openshift:enterprise-4.14 Oct 25, 2023

abhatt-rh removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 25, 2023

Conversation

amolnar-gh commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 25, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 25, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 25, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amolnar-gh commented Oct 25, 2023

Uh oh!

xenolinux commented Oct 25, 2023

Uh oh!

aireilly left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 25, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xenolinux left a comment

Choose a reason for hiding this comment

Uh oh!

xenolinux Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

xenolinux Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

amolnar-gh Oct 25, 2023

Choose a reason for hiding this comment

Uh oh!

xenolinux commented Oct 25, 2023

Uh oh!

abhatt-rh left a comment

Choose a reason for hiding this comment

Uh oh!

amolnar-gh commented Oct 25, 2023

Uh oh!

abhatt-rh commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

amolnar-gh commented Oct 25, 2023 •

edited

Loading

openshift-ci-robot commented Oct 25, 2023 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Oct 25, 2023 •

edited

Loading

openshift-ci-robot commented Oct 25, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 25, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 25, 2023 •

edited by openshift-ci bot

Loading