rn-4-14-clean: Scan 4.14 Release Notes for typos, and so on#67005
Merged
skrthomas merged 1 commit intoopenshift:enterprise-4.14from Oct 27, 2023
Merged
rn-4-14-clean: Scan 4.14 Release Notes for typos, and so on#67005skrthomas merged 1 commit intoopenshift:enterprise-4.14from
skrthomas merged 1 commit intoopenshift:enterprise-4.14from
Conversation
openshift-ci
bot
added
the
size/M
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/30684 |
dfitzmau
force-pushed
the
rn-4-14-clean
branch
from
85ae3cc to
9cc3000
Compare
openshift-ci
bot
added
size/L
dfitzmau
force-pushed
the
rn-4-14-clean
branch
6 times, most recently
from
3937e93 to
7cd69e4
Compare
Contributor
Author
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
dfitzmau
force-pushed
the
rn-4-14-clean
branch
2 times, most recently
from
465b5a2 to
7c7d16a
Compare
Contributor
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
Contributor
|
/remove-label peer-review-needed |
openshift-ci
bot
removed
the
peer-review-needed
ShaunaDiaz
reviewed
Oct 27, 2023
Contributor
ShaunaDiaz
left a comment
ShaunaDiaz
left a comment
There was a problem hiding this comment.
Nits on nits, right? As always, your call on which edits to accept. These look great!
| @@ -2901,11 +2925,11 @@ For any {product-title} release, always review the instructions on xref:../updat | |||
|
|
|||
| //Update with relevant advisory information | |||
| [id="ocp-4-14-0-ga"] | |||
| === RHSA-2023:1234 - {product-title} 4.14.0 image release, bug fix, and security update advisory | |||
| === RHSA-2023:1234 - {product-title} {product-version}.0 image release, bug fix, and security update advisory | |||
Contributor
There was a problem hiding this comment.
I think we have the ART Errata now? Can probably update these, too.
Contributor
Author
There was a problem hiding this comment.
Good catch, Shauna. Updated to match the advisory numbers on https://issues.redhat.com/browse/ART-7691.
@JoeAldinger . A further update is due for this section based on the completion of https://issues.redhat.com/browse/OSDOCS-8362 ?
Contributor
|
/label peer-review-done |
openshift-merge-robot
added
the
needs-rebase
Contributor
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
dfitzmau
force-pushed
the
rn-4-14-clean
branch
from
7c7d16a to
3e822db
Compare
openshift-merge-robot
removed
the
needs-rebase
dfitzmau
force-pushed
the
rn-4-14-clean
branch
from
3e822db to
d306726
Compare
dfitzmau
force-pushed
the
rn-4-14-clean
branch
from
d306726 to
0cac29a
Compare
Contributor
Author
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
skrthomas
added
merge-review-in-progress
Contributor
|
Very thorough good fixes here! 🔍 /lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[INTERNAL FIX FROM RELEASE NOTES TEAM]
Version(s):
4.14
Link to docs preview:
OCP 4.14 RN doc
QE review: No QE approval needed.
Additional information:
Pre-published 4.14 RN doc