Service Mesh docs fixes during ROSA review#67896
Conversation
openshift-ci
bot
added
size/S
|
🤖 Thu Mar 28 18:16:40 - Prow CI generated the docs preview: |
openshift-ci
bot
added
size/L
openshift-merge-robot
added
the
needs-rebase
mburke5678
force-pushed
the
service-mesh-fix-errors
branch
from
7a72959 to
53b469e
Compare
openshift-merge-robot
removed
the
needs-rebase
mburke5678
force-pushed
the
service-mesh-fix-errors
branch
from
3aad910 to
e6a9507
Compare
mburke5678
force-pushed
the
service-mesh-fix-errors
branch
2 times, most recently
from
5a9bf9b to
d00174a
Compare
openshift-ci
bot
added
peer-review-in-progress
| //// | ||
| This module is included in the following assemblies: | ||
| * service_mesh/v2x/ossm-create-smcp.adoc | ||
| //// |
There was a problem hiding this comment.
Luv ya man, meenit. :-D
| . Click the YAML tab. | ||
|
|
||
| . Modify the YAML to add projects as members (or delete them to remove existing members). You can add any number of projects, but a project can only belong to *one* `ServiceMeshMemberRoll` resource. | ||
| . Modify the YAML to add projects as members (or delete them to remove existing members). You can add any number of projects, but a project can only belong to one `ServiceMeshMemberRoll` resource. |
There was a problem hiding this comment.
Someone got WILD with the word "one". :-D
| - Name: Service Mesh 2.x release notes | ||
| File: servicemesh-release-notes | ||
| - Name: Service Mesh architecture | ||
| - Name: Understanding Service Mesh |
There was a problem hiding this comment.
| - Name: Understanding Service Mesh | |
| - Name: Understanding Service Mesh |
There was a problem hiding this comment.
This adds the title "Understanding Service Mesh" twice: One at the "top level" menu item and one immediately underneath. The adjacent repetition looks a little odd. I'd suggest the 2nd level title be "A network of microservices", but honestly, I am not at all sure that's an improvement.
|
@mburke5678 I put a question in this peer review but still, I believe an LGTM is appropriate. |
|
/label peer-review-done |
openshift-ci
bot
added
peer-review-done
mburke5678
force-pushed
the
service-mesh-fix-errors
branch
from
7af1968 to
a0e90ac
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.12 |
1 similar comment
|
/cherrypick enterprise-4.12 |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
@mburke5678: new pull request created: #73919 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #73920 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #73921 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #73922 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #73923 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Fixing various errors in the Applications docs as I find them during the ROSA content port. Mostly formatting, wording, and such.
Previews:
Understanding Service Mesh -- Updated topic map to match the assembly name. Current docs.
Configuring distributed tracing security for service mesh from the command line -- Updated step 3 and 5 based on experienced. Current docs.
Configuring distributed tracing security for service mesh from the web console -- Formatting changes.
Managing certificates with Elasticsearch -- Removed version-specific prereqs.
Adding or removing projects from the mesh using ServiceMeshMemberRoll resource with the CLI -- Formatting changes.
Adding or removing projects from the mesh using the ServiceMeshMemberRoll resource with the web console -- Formatting changes.
Adding a project to the mesh using the ServiceMeshMember resource with the CLI -- Moved verification steps into a new verification section.
Adding a project to the mesh using the ServiceMeshMember resource with the web console -- Moved verification steps into a new verification section.
Service Mesh architecture -- Fixed typo in third paragraph.
Configuring the Service Mesh Operator to run on infrastructure nodes -- Added metadata to code block in step 3.
Deploying the Service Mesh control plane from the web console -- Split Step 6 into substeps. Moved verification steps into a new verification section. Current docs.
3scale configuration -- Assembly doesn't seem to appear in docs. Added metadata to code block.
Configuring the control plane for cluster-wide deployment with the CLI -- Added new prereq (Needs QE), swapped period for a colon, moved verify steps to new section.
Configuring the control plane for cluster-wide deployment with the web console -- Added new prereq (Needs QE), swapped period for a colon, moved verify steps to new section.
Deploying the distributed tracing platform -- Fixed [source] in Production distributed tracing platform (Jaeger) deployment, Control plane with linked Jaeger production CR, Control plane with linked Jaeger streaming CR examples.
Installing the Operators -- Split Step 6, bullet 3 into separate bullets. Moved verification steps into a new verification section.
Operator overview -- Added parenthesis to Kiali Operator (provided by Red Hat) for searchability in the console.
Creating the member roll from the web console -- Removed unneeded bolding on
onein Step 8.Creating the member roll from the CLI -- Removed unneeded bolding on
onein Step 3.Adding or removing projects from the service mesh (v1) -- Removed unneeded bolding on
onein second bulletAdding or removing projects from the member roll using the web console (v1) -- Removed unneeded bolding on
onein Step 8.Adding or removing projects from the member roll using the CLI (v1)
QE review: