Skip to content

TELCODOCS-420: Adding release note for new MetalLB metrics#69851

Merged
kelbrown20 merged 1 commit intoopenshift:enterprise-4.15from
rohennes:TELCODOCS-420-RN
Jan 22, 2024
Merged

TELCODOCS-420: Adding release note for new MetalLB metrics#69851
kelbrown20 merged 1 commit intoopenshift:enterprise-4.15from
rohennes:TELCODOCS-420-RN

Conversation

@rohennes
Copy link
Contributor

@rohennes rohennes commented Jan 5, 2024 •
edited
Loading

TELCODOCS-420: Additional MetalLB Metrics release note

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/TELCODOCS-420

Link to docs preview:
https://69851--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes#ocp-4-15-metallb-metrics

QE review:

  • QE has approved this change.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2024 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-420 which is a valid jira issue.

Details

In response to this:

TELCODOCS-420: Additional MetalLB Metrics release note

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/TELCODOCS-420

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2024 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-420 which is a valid jira issue.

Details

In response to this:

TELCODOCS-420: Additional MetalLB Metrics release note

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/TELCODOCS-420

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 5, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 5, 2024 •
edited
Loading

🤖 Mon Jan 22 17:14:56 - Prow CI generated the docs preview: https://69851--ocpdocs-pr.netlify.app

@rohennes rohennes force-pushed the TELCODOCS-420-RN branch 2 times, most recently from 88fbd69 to 943c463 Compare January 5, 2024 11:28
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2024 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-420 which is a valid jira issue.

Details

In response to this:

TELCODOCS-420: Additional MetalLB Metrics release note

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/TELCODOCS-420

Link to docs preview:
https://69851--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes#ocp-4-15-metallb-metrics

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes rohennes force-pushed the TELCODOCS-420-RN branch 2 times, most recently from bc76a32 to a09f782 Compare January 5, 2024 11:44
@liornoy
Copy link

liornoy commented Jan 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
kononovn
kononovn approved these changes Jan 22, 2024
View reviewed changes
Copy link

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2024

@kononovn: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 22, 2024 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-420 which is a valid jira issue.

Details

In response to this:

TELCODOCS-420: Additional MetalLB Metrics release note

Version(s):
4.15

Issue:
https://issues.redhat.com/browse/TELCODOCS-420

Link to docs preview:
https://69851--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-15-release-notes#ocp-4-15-metallb-metrics

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rohennes
Copy link
Contributor Author

rohennes commented Jan 22, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 22, 2024
@rohennes
Copy link
Contributor Author

rohennes commented Jan 22, 2024

/label peer-review-needed

@eohartman
Copy link
Contributor

eohartman commented Jan 22, 2024

/label peer-review-in-progress

@JoeAldinger JoeAldinger added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 22, 2024
JoeAldinger
JoeAldinger reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion for minimalism.

release_notes/ocp-4-15-release-notes.adoc Outdated
[id="ocp-4-15-metallb-metrics"]
==== Additional BGP metrics for MetalLB

With this update, MetalLB exposes additional metrics relating to communication between MetalLB and Border Gateway Protocol (BGP) peers. For more information about these metrics, see xref:../networking/metallb/metallb-troubleshoot-support.adoc#nw-metallb-metrics_metallb-troubleshoot-support[MetalLB metrics for BGP and BFD].
Copy link
Contributor

@JoeAldinger JoeAldinger Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With this update, MetalLB exposes additional metrics relating to communication between MetalLB and Border Gateway Protocol (BGP) peers. For more information about these metrics, see xref:../networking/metallb/metallb-troubleshoot-support.adoc#nw-metallb-metrics_metallb-troubleshoot-support[MetalLB metrics for BGP and BFD].
With this update, MetalLB exposes additional metrics relating to communication between MetalLB and Border Gateway Protocol (BGP) peers. For more information, see xref:../networking/metallb/metallb-troubleshoot-support.adoc#nw-metallb-metrics_metallb-troubleshoot-support[MetalLB metrics for BGP and BFD].

@JoeAldinger JoeAldinger added this to the Planned for 4.15 GA milestone Jan 22, 2024
@JoeAldinger JoeAldinger added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.15 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 22, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2024

New changes are detected. LGTM label has been removed.

@rohennes
Copy link
Contributor Author

rohennes commented Jan 22, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 22, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jan 22, 2024

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kelbrown20 kelbrown20 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 22, 2024
kelbrown20
kelbrown20 reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM!

@kelbrown20 kelbrown20 merged commit 51acecb into openshift:enterprise-4.15 Jan 22, 2024
@kelbrown20 kelbrown20 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeAldinger JoeAldinger JoeAldinger left review comments

+2 more reviewers

@kelbrown20 kelbrown20 kelbrown20 left review comments

@kononovn kononovn kononovn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liornoy liornoy

Labels

branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.15 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@rohennes @openshift-ci-robot @ocpdocs-previewbot @liornoy @eohartman @kononovn @kelbrown20 @JoeAldinger