Skip to content

OCP 4.15 Release Notes for P/Z#70664

Merged
JoeAldinger merged 1 commit intoopenshift:enterprise-4.15from
alishaIBM:415-rn
Feb 21, 2024
Merged

OCP 4.15 Release Notes for P/Z#70664
JoeAldinger merged 1 commit intoopenshift:enterprise-4.15from
alishaIBM:415-rn

Conversation

@alishaIBM
Copy link
Contributor

@alishaIBM alishaIBM commented Jan 23, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 23, 2024 •
edited
Loading

🤖 Wed Feb 21 04:48:13 - Prow CI generated the docs preview: https://70664--ocpdocs-pr.netlify.app

@alishaIBM alishaIBM changed the title OCP 4.15 Release Notes for P/Z [WIP] OCP 4.15 Release Notes for P/Z Jan 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2024
SNiemann15
SNiemann15 suggested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@SNiemann15 SNiemann15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alishaIBM Only use the {ibm-xxx-title} attributes in titles or when referencing to titles. Otherwise use: {ibm-xxx-name}
I've left suggestions for IBM Z apply that to the Power part too.

@alishaIBM alishaIBM force-pushed the 415-rn branch 4 times, most recently from 651e657 to 664e0e4 Compare January 24, 2024 10:20
prb112
prb112 reviewed Jan 24, 2024
View reviewed changes
SNiemann15
SNiemann15 reviewed Feb 9, 2024
View reviewed changes
SNiemann15
SNiemann15 reviewed Feb 9, 2024
View reviewed changes
SNiemann15
SNiemann15 reviewed Feb 9, 2024
View reviewed changes
@alishaIBM alishaIBM force-pushed the 415-rn branch 3 times, most recently from f2e73a7 to 45d9ecd Compare February 15, 2024 10:56
@alishaIBM alishaIBM changed the title [WIP] OCP 4.15 Release Notes for P/Z OCP 4.15 Release Notes for P/Z Feb 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2024
@holgwolf
Copy link

holgwolf commented Feb 16, 2024

LGTM

@alishaIBM alishaIBM force-pushed the 415-rn branch 2 times, most recently from b9628b7 to 597370a Compare February 16, 2024 18:15
alishaIBM
alishaIBM commented Feb 16, 2024
View reviewed changes
release_notes/ocp-4-15-release-notes.adoc Outdated
Comment on lines 187 to 189
* Multi-architecture Power Control Plane with support of Intel and {ibm-power-name} workers
* nx-gzip for Power10 (Hardware Acceleration)
* openshift-install to support various SMT levels on {ibm-power-name} (Hardware Acceleration)
Copy link
Contributor Author

@alishaIBM alishaIBM Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prb112 request you to review above component names once again. The update is I have added {ibm-power-name}.

Copy link

@prb112 prb112 Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

@prb112 prb112 Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alishaIBM
Copy link
Contributor Author

alishaIBM commented Feb 16, 2024

/assign @manojnkumar

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@alishaIBM
Copy link
Contributor Author

alishaIBM commented Feb 20, 2024

/label peer-review-needed

fyi: QE approval pending.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 20, 2024
@xenolinux
Copy link
Contributor

xenolinux commented Feb 20, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 20, 2024
xenolinux
xenolinux reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments; otherwise LGTM!

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 20, 2024
@manojnkumar
Copy link

manojnkumar commented Feb 20, 2024

LGTM

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 20, 2024

New changes are detected. LGTM label has been removed.

@alishaIBM
Copy link
Contributor Author

alishaIBM commented Feb 20, 2024

/label merge-review-needed

fyi: QE has approved this change.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 20, 2024
@adellape adellape self-assigned this Feb 20, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 20, 2024
adellape
adellape reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment I'd like to hold merge on. Please re-queue for merge after addressing. Thank you!

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 20, 2024
@adellape adellape added this to the Planned for 4.15 GA milestone Feb 20, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2024

@alishaIBM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alishaIBM
Copy link
Contributor Author

alishaIBM commented Feb 21, 2024

/label merge-review-needed

Just one comment I'd like to hold merge on. Please re-queue for merge after addressing. Thank you!

Addressed the comments. Re-queuing for merge. Thanks. FYI: @adellape

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 21, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 21, 2024
JoeAldinger
JoeAldinger approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question for future consideration. lgtm

@JoeAldinger JoeAldinger merged commit 95cf07e into openshift:enterprise-4.15 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

@JoeAldinger JoeAldinger JoeAldinger approved these changes

+3 more reviewers

@prb112 prb112 prb112 approved these changes

@adellape adellape adellape left review comments

@SNiemann15 SNiemann15 SNiemann15 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@prb112 prb112

@adellape adellape

@manojnkumar manojnkumar

Labels

branch/enterprise-4.15 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.15 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@alishaIBM @ocpdocs-previewbot @holgwolf @xenolinux @manojnkumar @prb112 @adellape @SNiemann15 @JoeAldinger