Skip to content

TELCODOCS-1685 - Reuse the ArgoCD patch steps for ZTP install and upgrade procedures#70737

Merged
aireilly merged 1 commit intoopenshift:mainfrom
aireilly:TELCODOCS-1685
Feb 22, 2024
Merged

TELCODOCS-1685 - Reuse the ArgoCD patch steps for ZTP install and upgrade procedures#70737
aireilly merged 1 commit intoopenshift:mainfrom
aireilly:TELCODOCS-1685

Conversation

@aireilly
Copy link
Contributor

@aireilly aireilly commented Jan 24, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 24, 2024 •
edited
Loading

🤖 Thu Feb 22 16:25:49 - Prow CI generated the docs preview: https://70737--ocpdocs-pr.netlify.app

@aireilly aireilly requested a review from imiller0 January 24, 2024 17:29
@aireilly
Copy link
Contributor Author

aireilly commented Jan 24, 2024

@imiller0 PTAL

@aireilly
Copy link
Contributor Author

aireilly commented Jan 24, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 24, 2024
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.14 branch/enterprise-4.15 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 24, 2024
@stevsmit stevsmit added this to the Continuous Release milestone Jan 24, 2024
stevsmit
stevsmit reviewed Jan 24, 2024
View reviewed changes
@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 24, 2024
@stevsmit
Copy link
Member

stevsmit commented Jan 24, 2024

Just a few nits.

mletalie
mletalie reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 24, 2024
mletalie
mletalie reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 24, 2024
@aireilly aireilly force-pushed the TELCODOCS-1685 branch 2 times, most recently from b345b67 to 0edacb1 Compare January 25, 2024 13:17
@aireilly
Copy link
Contributor Author

aireilly commented Jan 29, 2024

@mpmaruthu Can you PTAL at this

@mpmaruthu
Copy link

mpmaruthu commented Jan 29, 2024

Telco RAN QE: Looks good to me.
/Peri M

@imiller0
Copy link

imiller0 commented Feb 22, 2024 •
edited
Loading

Content LGTM
One note on the rendered version is that the procedure numbering has two "1. ..." in this link:
https://70737--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-preparing-the-hub-cluster#ztp-configuring-hub-cluster-with-argocd_ztp-preparing-the-hub-cluster

@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2024

@aireilly: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aireilly aireilly merged commit 6db3f10 into openshift:main Feb 22, 2024
@aireilly
Copy link
Contributor Author

aireilly commented Feb 22, 2024

/cherrypick enterprise-4.14

@aireilly
Copy link
Contributor Author

aireilly commented Feb 22, 2024

/cherrypick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 22, 2024

@aireilly: new pull request created: #72061

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 22, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 22, 2024

@aireilly: new pull request created: #72062

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevsmit stevsmit stevsmit left review comments

@mletalie mletalie mletalie left review comments

@imiller0 imiller0 Awaiting requested review from imiller0

Assignees

No one assigned

Labels

branch/enterprise-4.14 branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@aireilly @ocpdocs-previewbot @stevsmit @mpmaruthu @imiller0 @openshift-cherrypick-robot @mletalie